Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2090463002: Move net/base/test_data_directory.[cc,h] to net/test (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
stevenjb, eroman, brettw
CC:
chromium-reviews, certificate-transparency-chrome_googlegroups.com, Eran Messeri, tzik, nasko+codewatch_chromium.org, nyquist+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, shaktisahu+watch-blimp_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, maniscalco+watch-blimp_chromium.org, gavinp+disk_chromium.org, chromoting-reviews_chromium.org, jam, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, darin-cc_chromium.org, lethalantidote+watch-blimp_chromium.org, loading-reviews_chromium.org, chromium-apps-reviews_chromium.org, blink-worker-reviews_chromium.org, creis+watch_chromium.org, jsbell+serviceworker_chromium.org, Randy Smith (Not in Mondays), nhiroki, oshima+watch_chromium.org, kinuko+cache_chromium.org, khushalsagar+watch-blimp_chromium.org, michaeln, anandc+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tfarina, serviceworker-reviews, kinuko+serviceworker, davemoore+watch_chromium.org, horo+watch_chromium.org, dtrainor+watch-blimp_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move net/base/test_data_directory.[cc,h] to net/test BUG=none TBR=brettw@chromium.org, stevenjb@chromium.org Committed: https://crrev.com/a69c79a742baf63c5a1a43edd6984c430b47c07b Cr-Commit-Position: refs/heads/master@{#401194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -178 lines) Patch
M blimp/client/session/assignment_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/certificate_provider/certificate_provider_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/client_cert_store_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/network_configuration_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_websocket_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/proxy_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/websocket_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_expect_ct_reporter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/chrome_ssl_host_state_delegate_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_client_certificate_selector_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/certificate_selector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ssl_client_certificate_selector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/net/x509_certificate_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cert_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/auto_connect_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/client_cert_resolver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_cert_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_connection_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/certificate_reporting/error_report_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/mock_cert_verifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/quic_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/ios/test/quic_test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/security_state/security_state_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/ssl_errors/error_classification_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_loader_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/worker_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cert_host_pair_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cert_verifier_block_adapter_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ios/web/net/crw_cert_verification_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/android/keystore_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/base/test_data_directory.h View 1 chunk +0 lines, -29 lines 0 comments Download
D net/base/test_data_directory.cc View 1 chunk +0 lines, -36 lines 0 comments Download
M net/cert/caching_cert_verifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/cert/cert_verify_proc_whitelist_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_objects_extractor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_policy_enforcer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_serialization_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/cert/internal/parse_ocsp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/internal/signature_algorithm_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/merkle_tree_leaf_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/multi_log_ct_verifier_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/cert/multi_threaded_cert_verifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_cert_database_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/nss_profile_filter_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/test_root_certs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert/x509_certificate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cert_net/nss_ocsp_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/extras/sqlite/sqlite_channel_id_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/http/transport_security_state_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/net.gyp View 10 chunks +11 lines, -11 lines 0 comments Download
M net/quic/crypto/proof_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/crypto/proof_verifier_chromium_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/quic_chromium_client_session_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/quic_end_to_end_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/quic_http_stream_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/quic_stream_factory_test.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_chromium.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/ssl/client_cert_store_unittest-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/openssl_client_key_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 2 chunks +1 line, -1 line 0 comments Download
A + net/test/test_data_directory.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + net/test/test_data_directory.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_http_job_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M net/websockets/websocket_end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/protocol_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Ryan Sleevi
4 years, 6 months ago (2016-06-22 01:15:02 UTC) #2
eroman
lgtm
4 years, 6 months ago (2016-06-22 01:27:00 UTC) #3
Ryan Sleevi
Brett, Steven: TBR because it's just a file move in //net
4 years, 6 months ago (2016-06-22 01:33:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090463002/1
4 years, 6 months ago (2016-06-22 01:34:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 03:29:09 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 03:32:57 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a69c79a742baf63c5a1a43edd6984c430b47c07b
Cr-Commit-Position: refs/heads/master@{#401194}

Powered by Google App Engine
This is Rietveld 408576698