Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2090453002: swarmbucket: extend lease to include execution timeout (Closed)

Created:
4 years, 6 months ago by nodir1
Modified:
4 years, 6 months ago
Reviewers:
Vadim Sh., nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

swarmbucket: extend lease to include execution timeout The lease for build cr-buildbucket.appspot.com/b/9009485403632683376 for task chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10 expired before swarming task completed because lease expiration time was less than (expiration + execution_timeout). Fix that R=vadimsh@chromium.org BUG=622104 Committed: https://chromium.googlesource.com/infra/infra/+/45e81bfe53c7bfb92cc13606d62bfba134b2bdac

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove extra_time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M appengine/cr-buildbucket/swarming/swarming.py View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
nodir
PTAL
4 years, 6 months ago (2016-06-22 00:06:09 UTC) #3
Vadim Sh.
lgtm does lease time even make sense for swarminbucket tasks? https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/swarming/swarming.py File appengine/cr-buildbucket/swarming/swarming.py (right): https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/swarming/swarming.py#newcode312 ...
4 years, 6 months ago (2016-06-22 00:09:44 UTC) #4
nodir
it does not, but I am hesitant to make swarming-specific changes in buildbucket core without ...
4 years, 6 months ago (2016-06-22 00:15:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090453002/20001
4 years, 6 months ago (2016-06-22 00:16:16 UTC) #8
nodir
btw that task was executing for 3 hours
4 years, 6 months ago (2016-06-22 00:17:54 UTC) #9
Vadim Sh.
On 2016/06/22 00:17:54, nodir wrote: > btw that task was executing for 3 hours 3 ...
4 years, 6 months ago (2016-06-22 00:21:14 UTC) #10
nodir
On 2016/06/22 00:21:14, Vadim Sh. wrote: > On 2016/06/22 00:17:54, nodir wrote: > > btw ...
4 years, 6 months ago (2016-06-22 00:24:26 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 12:48:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/45e81bfe53c7bfb92cc13606d62bf...

Powered by Google App Engine
This is Rietveld 408576698