swarmbucket: extend lease to include execution timeout

swarmbucket: extend lease to include execution timeout

The lease for build cr-buildbucket.appspot.com/b/9009485403632683376
for task
chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10
expired before swarming task completed because lease expiration time
was less than (expiration + execution_timeout). Fix that

R=vadimsh@chromium.org
BUG=622104
Committed: https://chromium.googlesource.com/infra/infra/+/45e81bfe53c7bfb92cc13606d62bfba134b2bdac

[nodir, 2016-06-21 23:55:05]

Description was changed from

==========
swarmbucket: extend lease to include execution timeout

The lease for build cr-buildbucket.appspot.com/b/9009485403632683376
for task
chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10
expired before swarming task completed because lease expiration time
was less than (expiration + execution_expiration). Fix that

R=vadimsh@chromium.org
BUG=622104
==========

to

==========
swarmbucket: extend lease to include execution timeout

The lease for build cr-buildbucket.appspot.com/b/9009485403632683376
for task
chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10
expired before swarming task completed because lease expiration time
was less than (expiration + execution_timeout). Fix that

R=vadimsh@chromium.org
BUG=622104
==========

[nodir, 2016-06-22 00:06:09]

nodir@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2016-06-22 00:06:09]

PTAL

[Vadim Sh., 2016-06-22 00:09:44]

lgtm

does lease time even make sense for swarminbucket tasks?

https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/sw...
File appengine/cr-buildbucket/swarming/swarming.py (right):

https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/sw...
appengine/cr-buildbucket/swarming/swarming.py:312: extra_time =
datetime.timedelta(hours=1)
it already included extra hour...

[nodir, 2016-06-22 00:15:45]

it does not, but I am hesitant to make swarming-specific changes in buildbucket
core without a strong reason

https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/sw...
File appengine/cr-buildbucket/swarming/swarming.py (right):

https://codereview.chromium.org/2090453002/diff/1/appengine/cr-buildbucket/sw...
appengine/cr-buildbucket/swarming/swarming.py:312: extra_time =
datetime.timedelta(hours=1)
On 2016/06/22 00:09:44, Vadim Sh. wrote:
> it already included extra hour...

removed it and added hour to task_expiration

[nodir, 2016-06-22 00:16:06]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-06-22 00:16:06]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2090453002/#ps20001
(title: "remove extra_time")

[commit-bot: I haz the power, 2016-06-22 00:16:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090453002/20001

[nodir, 2016-06-22 00:17:54]

btw that task was executing for 3 hours

[Vadim Sh., 2016-06-22 00:21:14]

On 2016/06/22 00:17:54, nodir wrote:
> btw that task was executing for 3 hours

3 hours spent in bot_update? Nice...

For chrome infra builders, we should limit them to 20 min or something. They
should be fast.

[nodir, 2016-06-22 00:24:26]

On 2016/06/22 00:21:14, Vadim Sh. wrote:
> On 2016/06/22 00:17:54, nodir wrote:
> > btw that task was executing for 3 hours
> 
> 3 hours spent in bot_update? Nice...
> 
> For chrome infra builders, we should limit them to 20 min or something. They
> should be fast.

sounds like swarmbucket builders must have execution_expiration_secs field

[commit-bot: I haz the power, 2016-06-22 12:48:58]

Description was changed from

==========
swarmbucket: extend lease to include execution timeout

The lease for build cr-buildbucket.appspot.com/b/9009485403632683376
for task
chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10
expired before swarming task completed because lease expiration time
was less than (expiration + execution_timeout). Fix that

R=vadimsh@chromium.org
BUG=622104
==========

to

==========
swarmbucket: extend lease to include execution timeout

The lease for build cr-buildbucket.appspot.com/b/9009485403632683376
for task
chromium-swarm.appspot.com/user/task/2f7e0c38fd997a10
expired before swarming task completed because lease expiration time
was less than (expiration + execution_timeout). Fix that

R=vadimsh@chromium.org
BUG=622104

Committed:
https://chromium.googlesource.com/infra/infra/+/45e81bfe53c7bfb92cc13606d62bf...
==========

[commit-bot: I haz the power, 2016-06-22 12:48:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/45e81bfe53c7bfb92cc13606d62bf...