Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 209043004: Revert 259287 "Add breakpad support for me2me and it2me native m..." (Closed)

Created:
6 years, 9 months ago by ernstm
Modified:
6 years, 9 months ago
Reviewers:
weitao
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 259287 "Add breakpad support for me2me and it2me native m..." Breaks Google Chrome build: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/49089/steps/compile/logs/stdio > Add breakpad support for me2me and it2me native messaging host on Mac. > > Changes in this CL include: > 1. Initialize breakpad in it2me native messaging host > 2. Create bundles for it2me and me2me native messaging hosts and move them out of the me2me host bundle (and update the manifests accordingly). > 3. Dump symbols of the it2me and me2me native messaging hosts > 4. Sign the me2me and it2me native messaging hosts > 4. Rename the me2me host bundle and the prefPane bundle to get rid of the internal chromium/chromoting names and to conform to Mac convention > 5. Refactor GYP, build-installer-archive.py, and do_signing.sh, etc to use name constants from branding_chrome and branding_chromium instead of hard coded names. This ensures that all the name constants are defined in a central location and reduces duplicate name definitions. > > Here are the names of the host bundles: > > me2me host: > old name: org.chromium.chromoting.me2me_host > new name: ChromeRemoteDesktop.Host > > Pref pane: > old name: org.chromium.chromoting.prefPane > new name: ChromeRemoteDesktop.prefPane > > it2me nm host: > name: NativeMessagingHost > Full Path: /Library/Google/ChromeRemoteDesktop/NativeMessagingHost.app > > me2me nm host: > name: RemoteAssistanceHost > Full path: /Library/Google/ChromeRemoteDesktop/RemoteAssistanceHost.app > > BUG= > > Review URL: https://codereview.chromium.org/186763004 TBR=weitaosu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259400

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -293 lines) Patch
M trunk/src/chrome/test/pyautolib/chromoting_helper.py View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/remoting/branding_Chrome View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/remoting/branding_Chromium View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/remoting/host/constants_mac.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M trunk/src/remoting/host/installer/mac/ChromotingHostService.pkgproj View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/remoting/host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh View 1 chunk +3 lines, -5 lines 0 comments Download
M trunk/src/remoting/host/installer/mac/do_signing.props View 1 chunk +3 lines, -7 lines 0 comments Download
M trunk/src/remoting/host/installer/mac/do_signing.sh View 2 chunks +10 lines, -20 lines 0 comments Download
D trunk/src/remoting/host/it2me/remote_assistance_host-Info.plist View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/remoting/host/it2me/remote_assistance_host-InfoPlist.strings.jinja2 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/remoting/host/setup/me2me_native_messaging_host_main.cc View 2 chunks +0 lines, -20 lines 0 comments Download
D trunk/src/remoting/host/setup/native_messaging_host-Info.plist View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/remoting/host/setup/native_messaging_host-InfoPlist.strings.jinja2 View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/remoting/remoting_host.gypi View 6 chunks +3 lines, -130 lines 0 comments Download
M trunk/src/remoting/remoting_host_mac.gypi View 4 chunks +9 lines, -14 lines 0 comments Download
M trunk/src/remoting/tools/get_mac_crd_version.sh View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ernstm
6 years, 9 months ago (2014-03-25 23:59:36 UTC) #1
ernstm
6 years, 9 months ago (2014-03-25 23:59:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r259400 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698