Issue 209042: Make Linux Breakpad initialization call to lsb_release asynchronous. Also wrap more...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209042: Make Linux Breakpad initialization call to lsb_release asynchronous. Also wrap more... (Closed)

Created:
11 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make Linux Breakpad initialization call to lsb_release asynchronous. Also wrap more things in USE_LINUX_BREAKPAD while we're at it. BUG=21782 TEST=Add time.sleep(10) to /usr/bin/lsb_release; starting Chrome should not take 10 seconds more. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27001

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -31 lines)			Patch
M	chrome/app/breakpad_linux.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/app/breakpad_linux.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	chrome/app/breakpad_linux_stub.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	6 chunks	+28 lines, -12 lines	1 comment	Download
M	chrome/browser/gtk/first_run_dialog.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/renderer/renderer_main.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

11 years, 3 months ago (2009-09-23 20:53:15 UTC) #3

LGTM.

(Sorry, this got lost in the post-vacation email load.)

http://codereview.chromium.org/209042/diff/1/6
File chrome/browser/browser_main.cc (left):

http://codereview.chromium.org/209042/diff/1/6#oldcode70
Line 70: #include "chrome/common/temp_scaffolding_stubs.h"
Make sure that the Mac tryservers are ok with this.

Expand Messages | Collapse Messages