Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.

test/mjsunit/harmony/dataview-accessors.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 382 matching lines @@
 
 TestOutOfRange();
 
 function TestGeneralAccessors() {
   var a = new DataView(new ArrayBuffer(256));
   function CheckAccessor(name) {
     var f = a[name];
     assertThrows(function() { f(); }, TypeError);
     f.call(a, 0, 0); // should not throw
     assertThrows(function() { f.call({}, 0, 0); }, TypeError);
-    assertThrows(function() { f.call(a); }, TypeError);
-    if (name.indexOf("set") == 0) {
-      assertThrows(function() { f.call(a, 1); }, TypeError);
-    } else {
-      f.call(a, 1); // should not throw
-    }
+    f.call(a);
+    f.call(a, 1); // should not throw
   }
   CheckAccessor("getUint8");
   CheckAccessor("setUint8");
   CheckAccessor("getInt8");
   CheckAccessor("setInt8");
   CheckAccessor("getUint16");
   CheckAccessor("setUint16");
   CheckAccessor("getInt16");
   CheckAccessor("setInt16");
   CheckAccessor("getUint32");
   CheckAccessor("setUint32");
   CheckAccessor("getInt32");
   CheckAccessor("setInt32");
   CheckAccessor("getFloat32");
   CheckAccessor("setFloat32");
   CheckAccessor("getFloat64");
   CheckAccessor("setFloat64");
 }
 
 TestGeneralAccessors();
 
 function TestInsufficientArguments() {
   var a = new DataView(new ArrayBuffer(256));
+  function CheckInsuficientArguments(type) {
+    var expectedValue = type === "Float32" || type === "Float64" ? NaN : 0;
+    var offset = getElementSize(type);
 
-  assertThrows(function() { a.getUint8(); }, TypeError);
-  assertThrows(function() { a.getInt8(); }, TypeError);
-  assertThrows(function() { a.getUint16(); }, TypeError);
-  assertThrows(function() { a.getInt16(); }, TypeError);
-  assertThrows(function() { a.getUint32(); }, TypeError);
-  assertThrows(function() { a.getInt32(); }, TypeError);
-  assertThrows(function() { a.getFloat32(); }, TypeError);
-  assertThrows(function() { a.getFloat64(); }, TypeError);
+    a["set" + type](0, 7);
+    a["set" + type]();

[Dan Ehrenberg, 2016/06/28 23:50:14]

Not sure why you're calling this function and throwing away the value. The
return value is specified, so better to check that you're getting what you
expect.

[bakkot, 2016/06/29 19:01:45]

Done, but I'm not sure how valuable it is to assert that it returns undefined.
We're calling these lines for their side effects, which we're verifying with the
next line.

[Dan Ehrenberg, 2016/06/29 19:13:42]

It's important that each function return the right value because whatever we
implement may be depended on by users. For example, another way to design
DataViews would be to return this, allowing chaining. The spec says not to do
this, though.

+    assertSame(expectedValue, a["get" + type]());
 
-  assertThrows(function() { a.setUint8(); }, TypeError);
-  assertThrows(function() { a.setInt8(); }, TypeError);
-  assertThrows(function() { a.setUint16(); }, TypeError);
-  assertThrows(function() { a.setInt16(); }, TypeError);
-  assertThrows(function() { a.setUint32(); }, TypeError);
-  assertThrows(function() { a.setInt32(); }, TypeError);
-  assertThrows(function() { a.setFloat32(); }, TypeError);
-  assertThrows(function() { a.setFloat64(); }, TypeError);
+    a["set" + type](offset, 7);
+    a["set" + type](offset);
+    assertSame(expectedValue, a["get" + type](offset));
+  }
 
-  assertThrows(function() { a.setUint8(1) }, TypeError);
-  assertThrows(function() { a.setInt8(1) }, TypeError);
-  assertThrows(function() { a.setUint16(1) }, TypeError);
-  assertThrows(function() { a.setInt16(1) }, TypeError);
-  assertThrows(function() { a.setUint32(1) }, TypeError);
-  assertThrows(function() { a.setInt32(1) }, TypeError);
-  assertThrows(function() { a.setFloat32(1) }, TypeError);
-  assertThrows(function() { a.setFloat64(1) }, TypeError);
+  CheckInsuficientArguments("Uint8");
+  CheckInsuficientArguments("Int8");
+  CheckInsuficientArguments("Uint16");
+  CheckInsuficientArguments("Int16");
+  CheckInsuficientArguments("Uint32");
+  CheckInsuficientArguments("Int32");
+  CheckInsuficientArguments("Float32");
+  CheckInsuficientArguments("Float64");
 }
 
 TestInsufficientArguments();