Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex.

test/mjsunit/harmony/dataview-accessors.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 382 matching lines @@
 
 TestOutOfRange();
 
 function TestGeneralAccessors() {
   var a = new DataView(new ArrayBuffer(256));
   function CheckAccessor(name) {
     var f = a[name];
     assertThrows(function() { f(); }, TypeError);
     f.call(a, 0, 0); // should not throw
     assertThrows(function() { f.call({}, 0, 0); }, TypeError);
-    assertThrows(function() { f.call(a); }, TypeError);
-    if (name.indexOf("set") == 0) {
-      assertThrows(function() { f.call(a, 1); }, TypeError);
-    } else {
-      f.call(a, 1); // should not throw
-    }
+    f.call(a);
+    f.call(a, 1); // should not throw
   }
   CheckAccessor("getUint8");
   CheckAccessor("setUint8");
   CheckAccessor("getInt8");
   CheckAccessor("setInt8");
   CheckAccessor("getUint16");
   CheckAccessor("setUint16");
   CheckAccessor("getInt16");
   CheckAccessor("setInt16");
   CheckAccessor("getUint32");
   CheckAccessor("setUint32");
   CheckAccessor("getInt32");
   CheckAccessor("setInt32");
   CheckAccessor("getFloat32");
   CheckAccessor("setFloat32");
   CheckAccessor("getFloat64");
   CheckAccessor("setFloat64");
 }
 
 TestGeneralAccessors();
 
 function TestInsufficientArguments() {
   var a = new DataView(new ArrayBuffer(256));
 
-  assertThrows(function() { a.getUint8(); }, TypeError);
-  assertThrows(function() { a.getInt8(); }, TypeError);
-  assertThrows(function() { a.getUint16(); }, TypeError);
-  assertThrows(function() { a.getInt16(); }, TypeError);
-  assertThrows(function() { a.getUint32(); }, TypeError);
-  assertThrows(function() { a.getInt32(); }, TypeError);
-  assertThrows(function() { a.getFloat32(); }, TypeError);
-  assertThrows(function() { a.getFloat64(); }, TypeError);
+  a.getUint8();
+  a.getInt8();
+  a.getUint16();
+  a.getInt16();
+  a.getUint32();
+  a.getInt32();
+  a.getFloat32();
+  a.getFloat64();
 
-  assertThrows(function() { a.setUint8(); }, TypeError);
-  assertThrows(function() { a.setInt8(); }, TypeError);
-  assertThrows(function() { a.setUint16(); }, TypeError);
-  assertThrows(function() { a.setInt16(); }, TypeError);
-  assertThrows(function() { a.setUint32(); }, TypeError);
-  assertThrows(function() { a.setInt32(); }, TypeError);
-  assertThrows(function() { a.setFloat32(); }, TypeError);
-  assertThrows(function() { a.setFloat64(); }, TypeError);
+  a.setUint8();
+  a.setInt8();
+  a.setUint16();
+  a.setInt16();
+  a.setUint32();
+  a.setInt32();
+  a.setFloat32();
+  a.setFloat64();
 
-  assertThrows(function() { a.setUint8(1) }, TypeError);
-  assertThrows(function() { a.setInt8(1) }, TypeError);
-  assertThrows(function() { a.setUint16(1) }, TypeError);
-  assertThrows(function() { a.setInt16(1) }, TypeError);
-  assertThrows(function() { a.setUint32(1) }, TypeError);
-  assertThrows(function() { a.setInt32(1) }, TypeError);
-  assertThrows(function() { a.setFloat32(1) }, TypeError);
-  assertThrows(function() { a.setFloat64(1) }, TypeError);
+  a.setUint8(1);
+  a.setInt8(1);
+  a.setUint16(1);
+  a.setInt16(1);
+  a.setUint32(1);
+  a.setInt32(1);
+  a.setFloat32(1);
+  a.setFloat64(1);

[Dan Ehrenberg, 2016/06/23 21:45:32]

Can you assert that these get values that make sense for 0 being passed as the
argument?

[bakkot, 2016/06/28 23:41:07]

Done.

 }
 
 TestInsufficientArguments();