ui: Fix faulty drm/gbm DCHECKs.

ui: Fix faulty drm/gbm DCHECKs.

- Remove a DCHECK in gl_image_ozone_native_pixmap_drm_unittest.cc that was
  checking drm permissions. The check is already done during Ozone
  initialization and the one in the test would always fail.

- Relax the check that the number of fds has to be the same as the number of
  planes when creating a gbm buffer.

BUG=618516
TEST='gl_unittests --gtest_also_run_disabled_tests' on cyan.

Committed: https://crrev.com/6537917f6f58a3d46d28f01de2a8ca98fb9c1b70
Cr-Commit-Position: refs/heads/master@{#401873}

[Daniele Castagna, 2016-06-23 22:22:51]

dcastagna@chromium.org changed reviewers:
+ posciak@chromium.org, reveman@chromium.org

[Daniele Castagna, 2016-06-23 22:22:52]

When I landed YV12 support I was testing it in release, and as Pawel noticed, a
few DCHECKs would fail.

This CL fixes those.

[Daniele Castagna, 2016-06-23 22:40:26]

Description was changed from

==========
ui: Fix faulty drm/gbm DCHECKs.

- Remove a DCHECK in gl_image_ozone_native_pixmap_drm_unittest.cc that was
  checking drm permissions. The check is already done during Ozone
  initialization and the one in the test would always fail.

- Relax the check that the number of fds has to be the same as the number of
  planes when creating a gbm buffer.

TEST='gl_unittests --gtest_also_run_disabled_tests' on cyan.
==========

to

==========
ui: Fix faulty drm/gbm DCHECKs.

- Remove a DCHECK in gl_image_ozone_native_pixmap_drm_unittest.cc that was
  checking drm permissions. The check is already done during Ozone
  initialization and the one in the test would always fail.

- Relax the check that the number of fds has to be the same as the number of
  planes when creating a gbm buffer.

BUG=618516
TEST='gl_unittests --gtest_also_run_disabled_tests' on cyan.
==========

[reveman, 2016-06-23 23:16:45]

ui/gl lgtm

[Daniele Castagna, 2016-06-23 23:37:39]

dcastagna@chromium.org changed reviewers:
+ dnicoara@chromium.org

[Daniele Castagna, 2016-06-23 23:37:39]

+dnicoara for ui/ozone approval.

[Pawel Osciak, 2016-06-24 00:52:54]

lgtm % nit

https://chromiumcodereview.appspot.com/2090343005/diff/20001/ui/ozone/platfor...
File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right):

https://chromiumcodereview.appspot.com/2090343005/diff/20001/ui/ozone/platfor...
ui/ozone/platform/drm/gpu/gbm_buffer.cc:145: DCHECK_LE(fds.size(),
strides.size());
Should we DCHECK offsets.size() as well (DCHECK_EQ(strides.size(),
offsets.size())?

[Daniele Castagna, 2016-06-24 01:16:16]

https://chromiumcodereview.appspot.com/2090343005/diff/20001/ui/ozone/platfor...
File ui/ozone/platform/drm/gpu/gbm_buffer.cc (right):

https://chromiumcodereview.appspot.com/2090343005/diff/20001/ui/ozone/platfor...
ui/ozone/platform/drm/gpu/gbm_buffer.cc:145: DCHECK_LE(fds.size(),
strides.size());
On 2016/06/24 at 00:52:54, Pawel Osciak wrote:
> Should we DCHECK offsets.size() as well (DCHECK_EQ(strides.size(),
offsets.size())?

Sure, done.

[dnicoara, 2016-06-24 13:52:07]

lgtm

[Daniele Castagna, 2016-06-24 15:19:52]

The CQ bit was checked by dcastagna@chromium.org

[Daniele Castagna, 2016-06-24 15:19:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, posciak@chromium.org
Link to the patchset: https://codereview.chromium.org/2090343005/#ps40001
(title: "Address posciak's comment.")

[commit-bot: I haz the power, 2016-06-24 15:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:23:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-24 16:25:18]

Description was changed from

==========
ui: Fix faulty drm/gbm DCHECKs.

- Remove a DCHECK in gl_image_ozone_native_pixmap_drm_unittest.cc that was
  checking drm permissions. The check is already done during Ozone
  initialization and the one in the test would always fail.

- Relax the check that the number of fds has to be the same as the number of
  planes when creating a gbm buffer.

BUG=618516
TEST='gl_unittests --gtest_also_run_disabled_tests' on cyan.
==========

to

==========
ui: Fix faulty drm/gbm DCHECKs.

- Remove a DCHECK in gl_image_ozone_native_pixmap_drm_unittest.cc that was
  checking drm permissions. The check is already done during Ozone
  initialization and the one in the test would always fail.

- Relax the check that the number of fds has to be the same as the number of
  planes when creating a gbm buffer.

BUG=618516
TEST='gl_unittests --gtest_also_run_disabled_tests' on cyan.

Committed: https://crrev.com/6537917f6f58a3d46d28f01de2a8ca98fb9c1b70
Cr-Commit-Position: refs/heads/master@{#401873}
==========

[commit-bot: I haz the power, 2016-06-24 16:25:19]

Patchset 3 (id:??) landed as
https://crrev.com/6537917f6f58a3d46d28f01de2a8ca98fb9c1b70
Cr-Commit-Position: refs/heads/master@{#401873}