Add GetUrl to DemuxerStreamProvider interface

media/base/android/media_url_provider.cc

Index: media/base/android/media_url_provider.cc
diff --git a/media/base/android/media_url_provider.cc b/media/base/android/media_url_provider.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c07f23ca120b957ca6e573f2fd66dc7e6d8d21fb
--- /dev/null
+++ b/media/base/android/media_url_provider.cc
@@ -0,0 +1,69 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "media/base/android/media_url_provider.h"
+
+#include "base/memory/ptr_util.h"
+
+namespace media {
+
+MediaUrlProvider::MediaUrlProvider(const GURL& url) : url_(url) {}
+
+MediaUrlProvider::~MediaUrlProvider() {}
+
+DemuxerStream* MediaUrlProvider::GetStream(DemuxerStream::Type type) {
+  return nullptr;
+}
+
+GURL* MediaUrlProvider::GetUrl() {

[DaleCurtis, 2016/06/24 00:42:30]

Don't typically return ptrs like this. I think for GURL it's comment to return a
copy or if this class will outlive all callers a const& is fine.

[tguilbert, 2016/06/24 03:13:19]

Yeah... I knew this would come up, and if it didn't I would have double checked
in person. My problem arose from wanting to distinguish between the empty case
and the null case.

I think the null case should probably not be a concern if I were to add the
DemuxerStreamProvider::Type as mentioned in the other file.

+  return &url_;
+}
+
+std::string MediaUrlProvider::GetDisplayName() const {
+  return "MediaUrlProvider";
+}
+
+void MediaUrlProvider::Initialize(DemuxerHost* host,
+                                  const PipelineStatusCB& status_cb,
+                                  bool enable_text_tracks) {
+  DVLOG(1) << __FUNCTION__;
+  status_cb.Run(PIPELINE_OK);
+}
+
+void MediaUrlProvider::StartWaitingForSeek(base::TimeDelta seek_time) {
+  DVLOG(1) << __FUNCTION__;

[DaleCurtis, 2016/06/24 00:42:30]

DVLOG(2) at least for this type of log, or delete all together if useless.

[tguilbert, 2016/06/24 03:13:19]

Done.

+}
+
+void MediaUrlProvider::CancelPendingSeek(base::TimeDelta seek_time) {
+  DVLOG(1) << __FUNCTION__;
+}
+
+void MediaUrlProvider::Seek(base::TimeDelta time,
+                            const PipelineStatusCB& status_cb) {
+  DVLOG(1) << __FUNCTION__;
+  status_cb.Run(PIPELINE_OK);
+}
+
+void MediaUrlProvider::Stop() {
+  DVLOG(1) << __FUNCTION__;
+}
+
+base::TimeDelta MediaUrlProvider::GetStartTime() const {
+  DVLOG(1) << __FUNCTION__;
+  // TODO(tguilbert): Investigate if we need to fetch information from the

[DaleCurtis, 2016/06/24 00:42:29]

I don't think this works today if it's > 0. Dunno if HLS clips can even start at
t > 0. I guess they should be able to, but don't know how we represent that to
blink.

[tguilbert, 2016/06/24 03:13:19]

My questioning came from the fact that, in the current prototype, if you toggle
full-screen (off/on/off), the timestamp is not preserved. The start time is
probably being picked up from somewhere else, but I just left this as a reminder
of a possible place to investigate.

+  // MediaPlayerRender in order to return a sensible value here.
+  return base::TimeDelta();
+}
+base::Time MediaUrlProvider::GetTimelineOffset() const {

[DaleCurtis, 2016/06/24 00:42:29]

I believe this should always be zero.

[tguilbert, 2016/06/24 03:13:19]

Acknowledged.

+  DVLOG(1) << __FUNCTION__;
+  // TODO(tguilbert): Return an appropriate value if needed.
+  return base::Time();
+}
+
+int64_t MediaUrlProvider::GetMemoryUsage() const {
+  // TODO(tguilbert): Verify this is an acceptable return value.

[DaleCurtis, 2016/06/24 00:42:30]

It is acceptable :)

[tguilbert, 2016/06/24 03:13:19]

Thank you!

+  return 0;
+}
+
+}  // namespace media