Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(990)

Issue 2090343003: Fix site-per-process layout tests timeouts due to document.write(). (Closed)

Created:
4 years, 6 months ago by alexmos
Modified:
4 years, 6 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix site-per-process layout tests timeouts due to document.write(). See detailed analysis in the bug. When the document.write() happened after document load, they implicitly called document.open() and dispatched another DidStartLoading, which might have prevented the main page (and the test) from finishing loading if it wasn't yet loaded at that point (due to the OOP subframe not yet loaded). Add a document.close() so that there's always going to be a matching DidStopLoading(). BUG=622764 Committed: https://crrev.com/4add5ff9d0fc7baec422201850dbfa829f516fb4 Cr-Commit-Position: refs/heads/master@{#401743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-shared-worker.html View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-worker-indexeddb.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alexmos
Daniel, can you please take a look?
4 years, 6 months ago (2016-06-23 16:45:10 UTC) #2
dcheng
The use of document.write here is questionable (don't we have a js-test.js thingie with logging ...
4 years, 6 months ago (2016-06-23 18:28:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090343003/1
4 years, 6 months ago (2016-06-23 22:11:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 22:16:53 UTC) #6
alexmos
On 2016/06/23 18:28:32, dcheng wrote: > The use of document.write here is questionable (don't we ...
4 years, 6 months ago (2016-06-23 22:17:19 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 22:18:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4add5ff9d0fc7baec422201850dbfa829f516fb4
Cr-Commit-Position: refs/heads/master@{#401743}

Powered by Google App Engine
This is Rietveld 408576698