Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2090343002: Fix build error with gcc 4.9.3 (Closed)

Created:
4 years, 6 months ago by Julien Isorce Samsung
Modified:
4 years, 6 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build error with gcc 4.9.3 native_backend_kwallet_x.cc:391:1: error: control reaches end of non-void function [-Werror=return-type] Regression introduced by https://codereview.chromium.org/2057123002 BUG=602624 R=vabr@chromium.org Committed: https://crrev.com/450339b9492844c74ba3b07aebca7d6c5770b984 Cr-Commit-Position: refs/heads/master@{#401601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/password_manager/native_backend_kwallet_x.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090343002/1
4 years, 6 months ago (2016-06-23 13:04:34 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-23 13:58:02 UTC) #4
Julien Isorce Samsung
On 2016/06/23 13:58:02, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-23 14:09:01 UTC) #5
vabr (Chromium)
On 2016/06/23 14:09:01, Julien Isorce wrote: > On 2016/06/23 13:58:02, commit-bot: I haz the power ...
4 years, 6 months ago (2016-06-23 14:26:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090343002/1
4 years, 6 months ago (2016-06-23 14:26:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 14:31:00 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 14:34:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/450339b9492844c74ba3b07aebca7d6c5770b984
Cr-Commit-Position: refs/heads/master@{#401601}

Powered by Google App Engine
This is Rietveld 408576698