src/objects-inl.h - Issue 2090333002: Use instance type in Object::IsErrorObject().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 2090333002: Use instance type in Object::IsErrorObject(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@RefactorToString

Patch Set: Refactor IsErrorObject() Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index fdd83e75da830603e45a358f6e51f15782d1d049..dc84ea5f7aeea081b35ddb78b1dd57582908c357 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -680,6 +680,10 @@ bool HeapObject::IsJSObject() const {

bool HeapObject::IsJSProxy() const { return map()->IsJSProxyMap(); }

+bool HeapObject::IsJSError() const {

+ return map()->instance_type() == JS_ERROR_TYPE;

TYPE_CHECKER(JSSet, JS_SET_TYPE)

TYPE_CHECKER(JSMap, JS_MAP_TYPE)

TYPE_CHECKER(JSSetIterator, JS_SET_ITERATOR_TYPE)