Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2090303003: Revert of Reland: Refactor process_resources.py to use aapt's --extra-packages (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland: Refactor process_resources.py to use aapt's --extra-packages (patchset #1 id:1 of https://codereview.chromium.org/2083383003/ ) Reason for revert: Broke webrtc GYP rules. Original issue's description: > Reland: Refactor process_resources.py to use aapt's --extra-packages > > Reason for Reland: > - No longer generating assignments for non-array styleable fields within > onResourcesLoaded() (matches aapt's behaviour) > > We actually never pass --include-all-resources, so this is just > refactoring dead code. I think it's an improvement though, > as the new comments explain more of why things work the way they do. > > TBR=agrieve > BUG=none > > Committed: https://crrev.com/c04a207f591c1cae455fee6c9c7d8b0dbca20abe > Cr-Commit-Position: refs/heads/master@{#401355} TBR=jbudorick@chromium.org,phoglund@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/932350f8583c875a222df3c3b7d9913418a2fe54 Cr-Commit-Position: refs/heads/master@{#401595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -120 lines) Patch
M build/android/gyp/process_resources.py View 10 chunks +91 lines, -120 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
agrieve
Created Revert of Reland: Refactor process_resources.py to use aapt's --extra-packages
4 years, 6 months ago (2016-06-23 13:09:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090303003/1
4 years, 6 months ago (2016-06-23 13:09:17 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 13:09:56 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/932350f8583c875a222df3c3b7d9913418a2fe54 Cr-Commit-Position: refs/heads/master@{#401595}
4 years, 6 months ago (2016-06-23 13:12:25 UTC) #6
agrieve
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2096693002/ by agrieve@chromium.org. ...
4 years, 6 months ago (2016-06-23 15:19:31 UTC) #7
agrieve
4 years, 6 months ago (2016-06-23 17:22:06 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2096763002/ by agrieve@chromium.org.

The reason for reverting is: Fixing.

Powered by Google App Engine
This is Rietveld 408576698