Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/perf/benchmarks/memory_infra.py

Issue 2090293002: Switch memory.blink_memory_mobile to TBMv2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/memory_infra.py
diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py
index fdece27ae74262c8fc94fd307e8bf315be22b98a..c32781c7cd28f59d392dc6a1c923543e02fc2f01 100644
--- a/tools/perf/benchmarks/memory_infra.py
+++ b/tools/perf/benchmarks/memory_infra.py
@@ -144,9 +144,9 @@ class DualBrowserBenchmark(_MemoryInfra):
@benchmark.Enabled('android')
class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
"""Timeline based benchmark for measuring memory consumption on mobile
- sites on which blink's memory consumption is relatively high."""
-
- _RE_RENDERER_VALUES = re.compile('memory_.+_renderer')
+ sites on which blink's memory consumption is relatively high.
+ """
+ TBM_VERSION = 2
nednguyen 2016/06/23 05:26:03 Why do we need this?
bashi 2016/06/23 05:29:24 The base class (_MemoryInfra.CreateTimelineBasedMe
nednguyen 2016/06/23 05:38:17 Acknowledged.
page_set = page_sets.BlinkMemoryMobilePageSet
@@ -165,7 +165,8 @@ class RendererMemoryBlinkMemoryMobile(_MemoryInfra):
@classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
- return bool(cls._RE_RENDERER_VALUES.match(value.name))
+ return (not _IGNORED_STATS_RE.search(value.name) and
+ 'renderer_process' in value.name)
petrcermak 2016/06/23 09:29:13 strictly speaking it should be 'renderer_processes
bashi 2016/06/23 23:01:18 Done.
class _MemoryV8Benchmark(_MemoryInfra):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698