Switch memory.blink_memory_mobile to TBMv2

Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/0d6528f73fa996e6c34d7f5ea2c08441efd99751
Cr-Commit-Position: refs/heads/master@{#401837}

[bashi, 2016-06-23 04:17:39]

Description was changed from

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
==========

to

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[bashi, 2016-06-23 04:18:31]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 04:18:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090293002/1

[bashi, 2016-06-23 04:37:48]

bashi@chromium.org changed reviewers:
+ nednguyen@google.com, petrcermak@chromium.org

[bashi, 2016-06-23 04:37:48]

petrcermak@, nednguyen@: PTAL.
tasak@: FYI

[nednguyen, 2016-06-23 05:26:03]

lgtm

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:149: TBM_VERSION = 2
Why do we need this?

[bashi, 2016-06-23 05:29:24]

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:149: TBM_VERSION = 2
On 2016/06/23 05:26:03, nednguyen wrote:
> Why do we need this?

The base class (_MemoryInfra.CreateTimelineBasedMeasurementOptions) uses it to
determine which version it should use. I think it will be gone after this CL.

[nednguyen, 2016-06-23 05:38:17]

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:149: TBM_VERSION = 2
On 2016/06/23 05:29:24, bashi1 wrote:
> On 2016/06/23 05:26:03, nednguyen wrote:
> > Why do we need this?
> 
> The base class (_MemoryInfra.CreateTimelineBasedMeasurementOptions) uses it to
> determine which version it should use. I think it will be gone after this CL.

Acknowledged.

[petrcermak, 2016-06-23 09:29:13]

LGTM with one optional comment.

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:169: 'renderer_process' in value.name)
strictly speaking it should be 'renderer_processes', but I guess it doesn't
really matter. Thanks!

[commit-bot: I haz the power, 2016-06-23 09:43:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 09:43:54]

Dry run: Try jobs failed on following builders:
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

[bashi, 2016-06-23 23:01:18]

Thanks for review!

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
File tools/perf/benchmarks/memory_infra.py (right):

https://codereview.chromium.org/2090293002/diff/1/tools/perf/benchmarks/memor...
tools/perf/benchmarks/memory_infra.py:169: 'renderer_process' in value.name)
On 2016/06/23 09:29:13, petrcermak wrote:
> strictly speaking it should be 'renderer_processes', but I guess it doesn't
> really matter. Thanks!

Done.

[bashi, 2016-06-23 23:01:23]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-06-23 23:01:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
nednguyen@google.com, petrcermak@chromium.org
Link to the patchset: https://codereview.chromium.org/2090293002/#ps20001
(title: "plural")

[commit-bot: I haz the power, 2016-06-23 23:02:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090293002/20001

[commit-bot: I haz the power, 2016-06-24 01:45:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:45:14]

Try jobs failed on following builders:
  winx64_10_perf_cq on tryserver.chromium.perf (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)

[bashi, 2016-06-24 05:17:44]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-06-24 05:18:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090293002/20001

[petrcermak, 2016-06-24 09:10:04]

Description was changed from

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[petrcermak, 2016-06-24 09:10:09]

The CQ bit was unchecked by petrcermak@chromium.org

[petrcermak, 2016-06-24 09:10:12]

The CQ bit was checked by petrcermak@chromium.org

[commit-bot: I haz the power, 2016-06-24 09:10:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2090293002/20001

[commit-bot: I haz the power, 2016-06-24 09:14:18]

Description was changed from

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

[commit-bot: I haz the power, 2016-06-24 09:14:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 09:16:08]

Description was changed from

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq
==========

to

==========
Switch memory.blink_memory_mobile to TBMv2

BUG=621034
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Committed: https://crrev.com/0d6528f73fa996e6c34d7f5ea2c08441efd99751
Cr-Commit-Position: refs/heads/master@{#401837}
==========

[commit-bot: I haz the power, 2016-06-24 09:16:09]

Patchset 2 (id:??) landed as
https://crrev.com/0d6528f73fa996e6c34d7f5ea2c08441efd99751
Cr-Commit-Position: refs/heads/master@{#401837}