Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 209029: Fix order of parameters for AutomationProvider::GetBooleanPreference(). (Closed)

Created:
11 years, 3 months ago by Roland
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Paweł Hajdan Jr.
Visibility:
Public.

Description

As described in issue 22236, AutomationProvider::GetBooleanPreference() currently has a wrong order of parameters. This patch fixes that. BUG=22236 TEST=none ATM, different return value expectations will be used in the upcoming UI test for automated encoding detection. (see http://codereview.chromium.org/173265). - TODO(rolandsteiner)

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/automation/automation_provider.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Roland
A fix for a bug that I found while implementing the UI test for encoding ...
11 years, 3 months ago (2009-09-18 12:42:28 UTC) #1
Johnny(Jianning) Ding
Nice catch. LGTM! One nit, please also change the order of comments for AutomationMsg_GetBooleanPreference definition ...
11 years, 3 months ago (2009-09-18 14:22:35 UTC) #2
Roland
On 2009/09/18 14:22:35, Johnny(Jianning) Ding wrote: > Nice catch. LGTM! > One nit, please also ...
11 years, 3 months ago (2009-09-24 11:33:02 UTC) #3
Johnny(Jianning) Ding
LGTM On 2009/09/24 11:33:02, Roland wrote: > On 2009/09/18 14:22:35, Johnny(Jianning) Ding wrote: > > ...
11 years, 3 months ago (2009-09-25 11:12:43 UTC) #4
Roland
On 2009/09/25 11:12:43, Johnny(Jianning) Ding wrote: > LGTM Need a kind committer now! ^_^
11 years, 2 months ago (2009-09-28 03:16:03 UTC) #5
jungshik at Google
11 years, 2 months ago (2009-09-28 18:55:01 UTC) #6
On 2009/09/28 03:16:03, Roland wrote:
> On 2009/09/25 11:12:43, Johnny(Jianning) Ding wrote:
> > LGTM
> 
> Need a kind committer now! ^_^

I'll land it for you.  BTW, shouldn't you apply for a provisional committership
(if not already)? :-)

Powered by Google App Engine
This is Rietveld 408576698