Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2090283002: add experimental param to control the triggering threshold to default Always Translate checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review issues Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/translate/core/browser/translate_ui_delegate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/translate/core/browser/translate_ui_delegate_unittest.cc
diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc
index 92656ff718485ad74dafeaa239eae59f9605cdb4..6d556f9bab3cd848959808aa17b36196582e8b00 100644
--- a/components/translate/core/browser/translate_ui_delegate_unittest.cc
+++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc
@@ -18,6 +18,7 @@
#include "components/translate/core/browser/translate_infobar_delegate.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
+#include "components/variations/variations_associated_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -195,7 +196,28 @@ TEST_F(TranslateUIDelegateTest, SetLanguageBlockedIn2016Q2UI) {
EXPECT_TRUE(manager_->GetLanguageState().translate_enabled());
}
-TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault) {
+TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefaultNever) {
+ std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
+ prefs->ResetTranslationAcceptedCount("ar");
+
+ for (int i = 0; i < 100; i++) {
+ EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault());
+ prefs->IncrementTranslationAcceptedCount("ar");
+ }
+}
+
+TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault2) {
+ const char kGroupName[] = "GroupA";
+ std::map<std::string, std::string> params = {
+ {kAlwaysTranslateOfferThreshold, "2"}};
+ variations::AssociateVariationParams(translate::kTranslateUI2016Q2TrialName,
+ kGroupName, params);
+ // need a trial_list to init the global instance used internally
+ // inside CreateFieldTrial().
+ base::FieldTrialList trial_list(nullptr);
+ base::FieldTrialList::CreateFieldTrial(translate::kTranslateUI2016Q2TrialName,
+ kGroupName);
+
std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
prefs->ResetTranslationAcceptedCount("ar");
« no previous file with comments | « components/translate/core/browser/translate_ui_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698