Chromium Code Reviews| Index: components/translate/core/browser/translate_ui_delegate_unittest.cc |
| diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc |
| index 92656ff718485ad74dafeaa239eae59f9605cdb4..4a3165b3db9a79fab688e6d52a8ebaea18d9c423 100644 |
| --- a/components/translate/core/browser/translate_ui_delegate_unittest.cc |
| +++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc |
| @@ -18,6 +18,7 @@ |
| #include "components/translate/core/browser/translate_infobar_delegate.h" |
| #include "components/translate/core/browser/translate_manager.h" |
| #include "components/translate/core/browser/translate_prefs.h" |
| +#include "components/variations/variations_associated_data.h" |
| #include "testing/gmock/include/gmock/gmock.h" |
| #include "testing/gtest/include/gtest/gtest.h" |
| #include "url/gurl.h" |
| @@ -195,7 +196,27 @@ TEST_F(TranslateUIDelegateTest, SetLanguageBlockedIn2016Q2UI) { |
| EXPECT_TRUE(manager_->GetLanguageState().translate_enabled()); |
| } |
| -TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault) { |
| +TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefaultNever) { |
| + std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs()); |
| + prefs->ResetTranslationAcceptedCount("ar"); |
| + |
| + for (int i = 0; i < 100; i++) { |
| + EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault()); |
| + prefs->IncrementTranslationAcceptedCount("ar"); |
| + } |
| +} |
| + |
| +TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault2) { |
| + std::unique_ptr<base::FieldTrialList> trial_list( |
| + new base::FieldTrialList(NULL)); |
|
Alexei Svitkine (slow)
2016/06/30 13:51:27
Nit: Just create this on the stack.
i.e.
base::F
|
| + const char kGroupName[] = "GroupA"; |
| + std::map<std::string, std::string> params = { |
| + {kAlwaysTranslateOfferThreshold, "2"}}; |
| + variations::AssociateVariationParams(translate::kTranslateUI2016Q2TrialName, |
| + kGroupName, params); |
| + base::FieldTrialList::CreateFieldTrial(translate::kTranslateUI2016Q2TrialName, |
| + kGroupName); |
| + |
| std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs()); |
| prefs->ResetTranslationAcceptedCount("ar"); |