Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: components/translate/core/browser/translate_ui_delegate_unittest.cc

Issue 2090283002: add experimental param to control the triggering threshold to default Always Translate checked (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use auto Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_ui_delegate_unittest.cc
diff --git a/components/translate/core/browser/translate_ui_delegate_unittest.cc b/components/translate/core/browser/translate_ui_delegate_unittest.cc
index 92656ff718485ad74dafeaa239eae59f9605cdb4..94c700f16e4cca73926ec91d2d0e1497c49812b2 100644
--- a/components/translate/core/browser/translate_ui_delegate_unittest.cc
+++ b/components/translate/core/browser/translate_ui_delegate_unittest.cc
@@ -18,6 +18,7 @@
#include "components/translate/core/browser/translate_infobar_delegate.h"
#include "components/translate/core/browser/translate_manager.h"
#include "components/translate/core/browser/translate_prefs.h"
+#include "components/variations/variations_associated_data.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
@@ -195,7 +196,27 @@ TEST_F(TranslateUIDelegateTest, SetLanguageBlockedIn2016Q2UI) {
EXPECT_TRUE(manager_->GetLanguageState().translate_enabled());
}
-TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault) {
+TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefaultNever) {
+ std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
+ prefs->ResetTranslationAcceptedCount("ar");
+
+ for (int i = 0; i < 100; i++) {
+ EXPECT_FALSE(delegate_->ShouldAlwaysTranslateBeCheckedByDefault());
+ prefs->IncrementTranslationAcceptedCount("ar");
+ }
+}
+
+TEST_F(TranslateUIDelegateTest, ShouldAlwaysTranslateBeCheckedByDefault2) {
+ std::unique_ptr<base::FieldTrialList> trial_list(
+ new base::FieldTrialList(NULL));
+ const char kGroupName[] = "GroupA";
+ std::map<std::string, std::string> params;
+ params[translate::kAlwaysTranslateOfferThreshold] = "2";
groby-ooo-7-16 2016/06/28 17:35:20 Use C++11 initializer lists: std::map<std::string
ftang 2016/06/28 21:51:12 cool. we can use C++11 in Chrome too? First time t
+ variations::AssociateVariationParams(translate::kTranslateUI2016Q2TrialName,
+ kGroupName, params);
+ base::FieldTrialList::CreateFieldTrial(translate::kTranslateUI2016Q2TrialName,
+ kGroupName);
+
std::unique_ptr<TranslatePrefs> prefs(client_->GetTranslatePrefs());
prefs->ResetTranslationAcceptedCount("ar");

Powered by Google App Engine
This is Rietveld 408576698