add experimental param to control the triggering threshold to default Always Translate checked

components/translate/core/browser/translate_prefs.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/translate/core/browser/translate_prefs.h"
 
 #include <set>
 
 #include "base/memory/ptr_util.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "build/build_config.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "components/prefs/scoped_user_pref_update.h"
 #include "components/translate/core/browser/translate_accept_languages.h"
 #include "components/translate/core/browser/translate_download_manager.h"
 #include "components/translate/core/browser/translate_experiment.h"
 #include "components/translate/core/common/translate_util.h"
+#include "components/variations/variations_associated_data.h"
 
 namespace translate {
 
 const char TranslatePrefs::kPrefTranslateSiteBlacklist[] =
     "translate_site_blacklist";
 const char TranslatePrefs::kPrefTranslateWhitelists[] = "translate_whitelists";
 const char TranslatePrefs::kPrefTranslateDeniedCount[] =
     "translate_denied_count_for_language";
 const char TranslatePrefs::kPrefTranslateIgnoredCount[] =
     "translate_ignored_count_for_language";
 const char TranslatePrefs::kPrefTranslateAcceptedCount[] =
     "translate_accepted_count";
 const char TranslatePrefs::kPrefTranslateBlockedLanguages[] =
     "translate_blocked_languages";
 const char TranslatePrefs::kPrefTranslateLastDeniedTimeForLanguage[] =
     "translate_last_denied_time_for_language";
 const char TranslatePrefs::kPrefTranslateTooOftenDeniedForLanguage[] =
     "translate_too_often_denied_for_language";
+const char kTranslateUI2016Q2TrialName[] = "TranslateUI2016Q2";
+const char kNumOfTranslationTriggerAlways[] =
+    "num_of_translation_trigger_always";
 
 // The below properties used to be used but now are deprecated. Don't use them
 // since an old profile might have some values there.
 //
 // * translate_last_denied_time
 // * translate_too_often_denied
 // * translate_language_blacklist
 
 namespace {
 
@@ skipping 393 matching lines @@
                                          std::string* target_language) {
   const base::DictionaryValue* dict =
       prefs_->GetDictionary(kPrefTranslateWhitelists);
   if (dict && dict->GetString(original_language, target_language)) {
     DCHECK(!target_language->empty());
     return !target_language->empty();
   }
   return false;
 }
 
+bool TranslatePrefs::ShouldAlwaysTranslateBeCheckedByDefault(

[groby-ooo-7-16, 2016/06/27 23:00:34]

This is moving even more policy decisions into prefs. When will we start moving
them out instead?

[ftang, 2016/06/28 05:01:46]

moved

+    const std::string& language) {
+  std::map<std::string, std::string> params;
+  int num_of_translation_trigger_default_checked = -1;

[groby-ooo-7-16, 2016/06/27 23:00:34]

StringToInt *will* force this to 0 on error.

[ftang, 2016/06/28 05:01:46]

Done.

+  if (variations::GetVariationParams(translate::kTranslateUI2016Q2TrialName,
+                                     &params)) {
+    std::map<std::string, std::string>::const_iterator it =

[groby-ooo-7-16, 2016/06/27 23:00:34]

auto it = params.find 

Or, if you want even shorter,
if (!variations::GetVariationsParam(...))
  return false;

base::StringToInt(params[translate::kNumOfTranslationTriggerAlways],
&threshold);
if (threshold <= 0)
  return false;

return GetTranslationAcceptedCount(language) >= threshold;


(Auto-creation of map members guarantees an empty string if the key is not
found, StringToInt will set Threshold to 0 when invalid or empty)

[ftang, 2016/06/28 05:01:46]

Done.

+        params.find(translate::kNumOfTranslationTriggerAlways);
+    if (it != params.end()) {
+      base::StringToInt(it->second,
+                        &num_of_translation_trigger_default_checked);
+    }
+  }
+
+  if (num_of_translation_trigger_default_checked < 0) {
+    return false;
+  }
+
+  // After N clicks on Translate for the same language.
+  // We check for == N instead of >= N because if the user translates with the
+  // "Always do this?" on, then the next time the bubble won't show up.
+  // The only chance the bubble will show up is after the user manually unchecks
+  // "Always do this?". In that case, since it is after user explictly unchecks,
+  // we should show as it as unchecked so we only check == N instead of >= N.
+  return GetTranslationAcceptedCount(language) ==
+         num_of_translation_trigger_default_checked;
+}
+
 // static
 void TranslatePrefs::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterListPref(kPrefTranslateSiteBlacklist,
                              user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterDictionaryPref(
       kPrefTranslateWhitelists,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterDictionaryPref(
       kPrefTranslateDeniedCount,
@@ skipping 99 matching lines @@
   const base::ListValue* blacklist = prefs_->GetList(pref_id);
   return (blacklist == NULL || blacklist->empty());
 }
 
 bool TranslatePrefs::IsDictionaryEmpty(const char* pref_id) const {
   const base::DictionaryValue* dict = prefs_->GetDictionary(pref_id);
   return (dict == NULL || dict->empty());
 }
 
 }  // namespace translate