Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2090263004: **WIP** Simple Cache: reduce seeks on stream 0 read.

Created:
4 years, 6 months ago by gavinp
Modified:
3 years, 4 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@simply-oom
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

**WIP** Simple Cache: reduce seeks on stream 0 read. Read the stream 0 (http headers) in a single read on opening an entry, rather than a series of seeks backwards in the file. Should improve performance since most OSes don't implement "read-behind" caching. Simultaneously significantly cleans up the logic for reading and sizing simple cache entries. BUG=xxx

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : merge to trunk #

Patch Set 4 : rebase better #

Patch Set 5 : rebase better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -6 lines) Patch
M net/disk_cache/simple/simple_synchronous_entry.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M net/disk_cache/simple/simple_synchronous_entry.cc View 1 2 3 chunks +116 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (8 generated)
gavinp
The CQ bit was checked by gavinp@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-12 22:06:25 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090263004/20001
3 years, 11 months ago (2017-01-12 22:07:27 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-12 22:21:51 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/341069)
3 years, 11 months ago (2017-01-12 22:21:51 UTC) #4
gavinp
The CQ bit was checked by gavinp@chromium.org to run a CQ dry run
3 years, 4 months ago (2017-08-10 18:42:49 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2090263004/80001
3 years, 4 months ago (2017-08-10 18:43:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 4 months ago (2017-08-10 18:52:33 UTC) #7
commit-bot: I haz the power
3 years, 4 months ago (2017-08-10 18:52:34 UTC) #8 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698