Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Issue 209022: Enable page load test on linux (Closed)

Created:
11 years, 3 months ago by Evan Stade
Modified:
9 years, 6 months ago
Reviewers:
huanr, Lei Zhang
CC:
chromium-reviews_googlegroups.com, Paweł Hajdan Jr.
Visibility:
Public.

Description

Break out page load test into its own target on Linux. Also, build the reliability_tests target on Linux. Neither of the new targets have trybots or buildbots yet, however, they do work for me locally. BUG=19085 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26530

Patch Set 1 #

Patch Set 2 : synced #

Patch Set 3 : '' #

Patch Set 4 : dont compile page load test on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -39 lines) Patch
M chrome/chrome.gyp View 1 2 3 4 chunks +67 lines, -30 lines 0 comments Download
M chrome/test/reliability/page_load_test.cc View 1 2 2 chunks +1 line, -8 lines 0 comments Download
M chrome/test/ui/ui_test.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Stade
11 years, 3 months ago (2009-09-17 23:18:29 UTC) #1
huanr
LGTM. Lei: when we get the bot that builds reliability_tests on Linux, in addition to ...
11 years, 3 months ago (2009-09-17 23:41:54 UTC) #2
Evan Stade
Just so I understand correctly, why do we need that? 1) isn't that essentially the ...
11 years, 3 months ago (2009-09-17 23:45:03 UTC) #3
huanr
For chromebot running with continuous build, each cycle may run 50-60k URLs and there could ...
11 years, 3 months ago (2009-09-17 23:55:39 UTC) #4
Evan Stade
for outside observers, the plan is indeed to use PageLoadTest.Reliability (I simply misunderstood him)
11 years, 3 months ago (2009-09-18 00:00:43 UTC) #5
Lei Zhang
11 years, 3 months ago (2009-09-18 00:26:24 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698