Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3104)

Unified Diff: cc/playback/clip_display_item.cc

Issue 2090203002: Remove antialiasing from views bounds rects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/clip_display_item.cc
diff --git a/cc/playback/clip_display_item.cc b/cc/playback/clip_display_item.cc
index 92166c15886582195382b73a9958177d76a71802..d09333ca2f8e7d3a4cdf3f72a53f7b81969b6668 100644
--- a/cc/playback/clip_display_item.cc
+++ b/cc/playback/clip_display_item.cc
@@ -20,10 +20,10 @@
namespace cc {
class ImageSerializationProcessor;
-ClipDisplayItem::ClipDisplayItem(
- const gfx::Rect& clip_rect,
- const std::vector<SkRRect>& rounded_clip_rects) {
- SetNew(clip_rect, rounded_clip_rects);
+ClipDisplayItem::ClipDisplayItem(const gfx::Rect& clip_rect,
+ const std::vector<SkRRect>& rounded_clip_rects,
+ bool antialiased) {
+ SetNew(clip_rect, rounded_clip_rects, antialiased);
}
ClipDisplayItem::ClipDisplayItem(const proto::DisplayItem& proto) {
@@ -36,13 +36,16 @@ ClipDisplayItem::ClipDisplayItem(const proto::DisplayItem& proto) {
for (int i = 0; i < details.rounded_rects_size(); i++) {
rounded_clip_rects.push_back(ProtoToSkRRect(details.rounded_rects(i)));
}
- SetNew(clip_rect, rounded_clip_rects);
+ bool antialias = details.antialias();
+ SetNew(clip_rect, rounded_clip_rects, antialias);
}
void ClipDisplayItem::SetNew(const gfx::Rect& clip_rect,
- const std::vector<SkRRect>& rounded_clip_rects) {
+ const std::vector<SkRRect>& rounded_clip_rects,
+ bool antialias) {
clip_rect_ = clip_rect;
rounded_clip_rects_ = rounded_clip_rects;
+ antialias_ = antialias;
}
ClipDisplayItem::~ClipDisplayItem() {}
@@ -58,12 +61,13 @@ void ClipDisplayItem::ToProtobuf(
for (const auto& rrect : rounded_clip_rects_) {
SkRRectToProto(rrect, details->add_rounded_rects());
}
+ details->set_antialias(antialias_);
}
void ClipDisplayItem::Raster(SkCanvas* canvas,
const gfx::Rect& canvas_target_playback_rect,
SkPicture::AbortCallback* callback) const {
- bool antialiased = true;
+ bool antialiased = antialias_;
danakj 2016/06/22 22:49:57 just use antialias_ throughout, drop the local var
Bret 2016/06/22 23:39:41 Done.
canvas->save();
canvas->clipRect(SkRect::MakeXYWH(clip_rect_.x(), clip_rect_.y(),
clip_rect_.width(), clip_rect_.height()),

Powered by Google App Engine
This is Rietveld 408576698