Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: src/js/array.js

Issue 2090193002: Array splice should only normalize deleted_elements if it's an array (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-618788.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/array.js
diff --git a/src/js/array.js b/src/js/array.js
index 671e507a1568bed82f41a6b1f7040c6493e6c867..355f9962b63a3cab5ae5d2088dfad0fa06b891ad 100644
--- a/src/js/array.js
+++ b/src/js/array.js
@@ -729,7 +729,7 @@ function ArraySplice(start, delete_count) {
}
if (UseSparseVariant(array, len, IS_ARRAY(array), changed_elements)) {
%NormalizeElements(array);
- %NormalizeElements(deleted_elements);
+ if (IS_ARRAY(deleted_elements)) %NormalizeElements(deleted_elements);
SparseSlice(array, start_i, del_count, len, deleted_elements);
SparseMove(array, start_i, del_count, len, num_elements_to_add);
} else {
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-618788.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698