Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2090193002: Array splice should only normalize deleted_elements if it's an array (Closed)

Created:
4 years, 6 months ago by adamk
Modified:
4 years, 6 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Array splice should only normalize deleted_elements if it's an array Also slightly expand regression test to end with a return instead of an exception. R=cbruni@chromium.org BUG=chromium:618788 Committed: https://crrev.com/7b011fc9db92da2802702ccfdd93b576e438ae04 Cr-Commit-Position: refs/heads/master@{#37223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M src/js/array.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-618788.js View 1 chunk +17 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
4 years, 6 months ago (2016-06-22 21:40:55 UTC) #1
Camillo Bruni
lgtm
4 years, 6 months ago (2016-06-23 12:24:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090193002/1
4 years, 6 months ago (2016-06-23 17:18:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 17:20:40 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 17:24:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b011fc9db92da2802702ccfdd93b576e438ae04
Cr-Commit-Position: refs/heads/master@{#37223}

Powered by Google App Engine
This is Rietveld 408576698