Moved methods that don't rely on internal state out of ChromeLauncherController.

chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..1a9b4009f7838f33182c06eacd7132452d0baa75
--- /dev/null
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h
@@ -0,0 +1,29 @@
+// Copyright (c) 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_
+#define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_
+
+#include "chrome/browser/ui/app_list/app_list_controller_delegate.h"
+#include "chrome/browser/ui/browser.h"
+#include "extensions/common/extension.h"
+
+namespace chrome {
+namespace util {

[mfomitchev, 2016/06/23 16:00:27]

I'd get rid of the namespaces. I think this should be in the same namespace as
ChromeLauncherController, i.e. the global namespace. chrome::util doesn't
currently exist, and creating a namespace just for this class doesn't seem
warranted. Also, if you take a look at other _util files in
chrome/browser/ui/ash - none of them are in a specialized namepsace.

[StarAZ, 2016/06/23 19:35:03]

Acknowledged.

+
+// Returns true if |browser| is owned by the active user.
+bool IsBrowserFromActiveUser(Browser* browser);
+
+// Returns the extension identified by |app_id|.
+const extensions::Extension* GetExtensionForAppID(Profile* profile,

[mfomitchev, 2016/06/23 16:00:27]

nit: make profile the second argument. Typically the more "important" arguments
are first. Profile is a global state that doesn't change much, whereas the
app_id actually corresponds to the thing you are querying here.

[StarAZ, 2016/06/23 19:35:03]

Acknowledged.

+                                                  const std::string& app_id);
+
+// TODO(khmel): Find better home for Pinnable enum.
+AppListControllerDelegate::Pinnable GetPinnable(Profile* profile,

[mfomitchev, 2016/06/23 16:00:27]

Perhaps rename GetPinnable to GetPinnableForAppID to make the usage more clear
now that this is not in ChromeLauncherController.

[mfomitchev, 2016/06/23 16:00:27]

Ditto

[StarAZ, 2016/06/23 19:35:03]

Acknowledged.

+                                                const std::string& app_id);
+
+}  // namespace util
+}  // namespace chrome
+
+#endif  // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_