chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc - Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nit changes Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

index 997b347871cd37f2fe947c75ff40939b157d9ab9..f5ef02fb431cdffedde3fbb9b19ab8a523720f61 100644

--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc

@@ -36,6 +36,7 @@

#include "chrome/browser/ui/app_list/app_list_service.h"

#include "chrome/browser/ui/ash/app_list/test/app_list_service_ash_test_api.h"

#include "chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h"

+#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h"

#include "chrome/browser/ui/ash/launcher/launcher_application_menu_item_model.h"

#include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"

#include "chrome/browser/ui/ash/launcher/launcher_item_controller.h"

@@ -2120,7 +2121,7 @@ IN_PROC_BROWSER_TEST_F(ShelfAppBrowserTest, V1AppNavigation) {

// Create a windowed application.

AppLaunchParams params = CreateAppLaunchParamsUserContainer(

- profile(), controller_->GetExtensionForAppID(extensions::kWebStoreAppId),

+ profile(), GetExtensionForAppID(extensions::kWebStoreAppId, profile()),

NEW_FOREGROUND_TAB, extensions::SOURCE_TEST);

params.container = extensions::LAUNCH_CONTAINER_WINDOW;

OpenApplication(params);