Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc

Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed redundant #include statements Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
index 2bebb9ce09fa2cf5be1a804eb9e1a19fe25b76c9..f0657e1f7682c5770fd06d1f13bb2d6e02c424da 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc
@@ -24,6 +24,7 @@
#include "ash/shelf/shelf_delegate.h"
#include "ash/shell.h"
#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
+#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h"
#endif
AppInfoFooterPanel::AppInfoFooterPanel(gfx::NativeWindow parent_window,
@@ -172,7 +173,8 @@ bool AppInfoFooterPanel::CanSetPinnedToShelf() const {
// The Chrome app can't be unpinned, and extensions can't be pinned.
return app_->id() != extension_misc::kChromeAppId && !app_->is_extension() &&
(!ChromeLauncherController::instance() ||
- ChromeLauncherController::instance()->GetPinnable(app_->id()) ==
+ GetPinnableForAppID(
+ app_->id(), ChromeLauncherController::instance()->GetProfile()) ==
tapted 2016/06/23 23:47:30 It's probably more correct to pass |profile_| here
tapted 2016/06/27 00:25:36 ping? (did you try this out?)
StarAZ 2016/06/27 14:22:47 Done.
AppListControllerDelegate::PIN_EDITABLE);
}
#endif // USE_ASH

Powered by Google App Engine
This is Rietveld 408576698