chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h - Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.h

Issue 2090133003: Moved methods that don't rely on internal state out of ChromeLauncherController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modifications according to the comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_

	6 #define CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_

	7

	8 #include "chrome/browser/ui/app_list/app_list_controller_delegate.h"

	9 #include "chrome/browser/ui/browser.h"
	mfomitchev 2016/06/23 19:41:57 Don't include browser.h and extension.h here, just Don't include browser.h and extension.h here, just forward-declare Browser and Extension (and include .h files in the .cc if needed). See https://www.chromium.org/developers/coding-style#TOC-Forward-declarations-vs.... StarAZ 2016/06/23 20:12:41 Done. Show quoted text On 2016/06/23 19:41:57, mfomitchev wrote: > Don't include browser.h and extension.h here, just forward-declare Browser and > Extension (and include .h files in the .cc if needed). See > https://www.chromium.org/developers/coding-style#TOC-Forward-declarations-vs.... Done.
	10 #include "extensions/common/extension.h"

	11

	12 // Returns true if \|browser\| is owned by the active user.

	13 bool IsBrowserFromActiveUser(Browser* browser);

	14

	15 // Returns the extension identified by \|app_id\|.

	16 const extensions::Extension* GetExtensionForAppID(const std::string& app_id,

	17 Profile* profile);

	18

	19 // TODO(khmel): Find better home for Pinnable enum.

	20 AppListControllerDelegate::Pinnable GetPinnableForAppID(

	21 const std::string& app_id,

	22 Profile* profile);

	23

	24 #endif // CHROME_BROWSER_UI_ASH_LAUNCHER_CHROME_LAUNCHER_CONTROLLER_UTIL_H_

OLD	NEW