update3dRenderingContext is 13.5% of GraphicsLayerUpdater::rebuildTree

Source/core/rendering/compositing/GraphicsLayerUpdater.cpp

 /*
  * Copyright (C) 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 48 matching lines @@
 {
 }
 
 void GraphicsLayerUpdater::rebuildTree(RenderLayer& layer, UpdateType updateType, GraphicsLayerVector& childLayersOfEnclosingLayer, int depth)
 {
     // Make the layer compositing if necessary, and set up clipping and content layers.
     // Note that we can only do work here that is independent of whether the descendant layers
     // have been processed. computeCompositingRequirements() will already have done the repaint if necessary.
 
     layer.stackingNode()->updateLayerListsIfNeeded();
-    layer.update3dRenderingContext();
 
     const bool hasCompositedLayerMapping = layer.hasCompositedLayerMapping();
     CompositedLayerMappingPtr currentCompositedLayerMapping = layer.compositedLayerMapping();
 
     updateType = update(layer, updateType);
 
     // Grab some stats for histograms.
     if (hasCompositedLayerMapping) {
         m_pixelsWithoutPromotingAllTransitions += layer.size().height() * layer.size().width();
     } else {
@@ skipping 72 matching lines @@
     LayerListMutationDetector mutationChecker(layer.stackingNode());
 #endif
 
     RenderLayerStackingNodeIterator iterator(*layer.stackingNode(), AllChildren);
     while (RenderLayerStackingNode* curNode = iterator.next())
         updateRecursive(*curNode->layer(), updateType);
 }
 
 GraphicsLayerUpdater::UpdateType GraphicsLayerUpdater::update(RenderLayer& layer, UpdateType updateType)
 {
+

[ojan, 2014/03/25 01:36:00]

Did you mean to add this?

[abarth-chromium, 2014/03/25 02:31:38]

Nope!  That was from an earlier iteration where I tried to move the work here.

     if (!layer.hasCompositedLayerMapping())
         return updateType;
 
     CompositedLayerMappingPtr mapping = layer.compositedLayerMapping();
 
     // Note carefully: here we assume that the compositing state of all descendants have been updated already,
     // so it is legitimate to compute and cache the composited bounds for this layer.
     mapping->updateCompositedBounds(updateType);
 
     if (RenderLayerReflectionInfo* reflection = layer.reflectionInfo()) {
         if (reflection->reflectionLayer()->hasCompositedLayerMapping())
             reflection->reflectionLayer()->compositedLayerMapping()->updateCompositedBounds(ForceUpdate);
     }
 
     mapping->updateGraphicsLayerConfiguration();
     updateType = mapping->updateGraphicsLayerGeometry(updateType);
     mapping->clearNeedsGeometryUpdate();
 
     if (!layer.parent())
         layer.compositor()->updateRootLayerPosition();
 
     if (mapping->hasUnpositionedOverflowControlsLayers())
         layer.scrollableArea()->positionOverflowControls();
 
     return updateType;
 }
 
 } // namespace WebCore