Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 209003012: Use requestAnimationFrame (without prefix) in calendar picker (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Use requestAnimationFrame (without prefix) in calendar picker This is a prerequisite for deprecating the prefixed function, because otherwise the forms tests get a deprecation message. This internal use of webkitRequestAnimationFrame may also have inflated the use counter data for it. BUG=354921 R=abarth@chromium.org, keishi@chromium.org, tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/web/resources/calendarPicker.js View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 37 (0 generated)
philipj_slow
tkent, I see you've done some work in this file, can you PTAL? https://codereview.chromium.org/208263005/ is ...
6 years, 9 months ago (2014-03-24 17:44:29 UTC) #1
abarth-chromium
lgtm
6 years, 9 months ago (2014-03-24 17:49:44 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 18:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-24 18:28:30 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:30:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 18:30:07 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 18:38:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-24 18:39:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:54:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-24 18:54:13 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 18:56:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-24 18:57:03 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:58:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 18:58:16 UTC) #14
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-24 19:03:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-24 19:03:54 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 19:06:27 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-24 19:06:27 UTC) #18
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 01:17:01 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-25 01:17:08 UTC) #20
tkent
lgtm
6 years, 9 months ago (2014-03-25 01:19:59 UTC) #21
keishi
lgtm
6 years, 9 months ago (2014-03-25 01:27:27 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 02:25:59 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 02:26:05 UTC) #24
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 03:54:27 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-25 03:54:32 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 05:04:36 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 05:04:36 UTC) #28
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 05:10:50 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-25 05:10:59 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 06:22:20 UTC) #31
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 06:22:21 UTC) #32
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-25 06:58:41 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/209003012/1
6 years, 9 months ago (2014-03-25 06:58:44 UTC) #34
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-25 08:02:24 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-25 08:02:25 UTC) #36
philipj_slow
6 years, 9 months ago (2014-03-25 08:10:03 UTC) #37
Message was sent while issue was closed.
Committed patchset #1 manually as r169918 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698