Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: runtime/vm/object.h

Issue 209003009: Fix memory-issue String::fromCharCodes, where a GC could invalidate an address. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index 6c71efdcb071cdfe28f7907b71412807a0357cd3..0789c0e3c1d812a102af3864f812e26df9ca46a2 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -5306,6 +5306,16 @@ class OneByteString : public AllStatic {
intptr_t other_len,
Heap::Space space);
+ static RawOneByteString* New(const TypedData& other_typed_data,
+ intptr_t other_start_index,
+ intptr_t other_len,
+ Heap::Space space = Heap::kNew);
+
+ static RawOneByteString* New(const ExternalTypedData& other_typed_data,
+ intptr_t other_start_index,
+ intptr_t other_len,
+ Heap::Space space = Heap::kNew);
+
static RawOneByteString* Concat(const String& str1,
const String& str2,
Heap::Space space);
« no previous file with comments | « runtime/lib/string.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698