Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 2090013002: [heap] Fix check in AdvancePage (Closed)

Created:
4 years, 6 months ago by Michael Lippautz
Modified:
4 years, 6 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix check in AdvancePage Failing to do the right check in AdvancePage results in a crash in a CHECK later in EnsureCurrentCapacity. BUG=chromium:620750, chromium:622115 LOG=N R=jochen@chromium.org Committed: https://crrev.com/21b55c4aa5fd47da0ef3802c88f6da41690b7d1f Cr-Commit-Position: refs/heads/master@{#37171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M src/heap/spaces.h View 1 chunk +5 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-620750.js View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Michael Lippautz
ptal
4 years, 6 months ago (2016-06-22 08:29:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090013002/20001
4 years, 6 months ago (2016-06-22 08:35:28 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 09:02:54 UTC) #9
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-22 09:03:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2090013002/20001
4 years, 6 months ago (2016-06-22 09:04:52 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-22 09:07:38 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:10:22 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21b55c4aa5fd47da0ef3802c88f6da41690b7d1f
Cr-Commit-Position: refs/heads/master@{#37171}

Powered by Google App Engine
This is Rietveld 408576698