MacViews: Explicitly release mouse capture in BridgedNativeWidget::OnWindowWillClose().

ui/views/widget/widget_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <memory>
 #include <set>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 1756 matching lines @@
 
   EXPECT_EQ(1, event_count_view->GetEventCount(ui::ET_MOUSE_PRESSED));
   EXPECT_EQ(
       widget->GetNativeView(),
       internal::NativeWidgetPrivate::GetGlobalCapture(widget->GetNativeView()));
 
   // For mus it's important we destroy the widget before the EventGenerator.
   widget->CloseNow();
 }
 
+// Verify capture is correctly set on a widget. Test for crbug.com/622201.

[tapted, 2016/06/23 02:26:28]

This doesn't describe the test well. It should be something like "Test to ensure
capture is correctly released from a Widget with capture when it is destroyed."

[karandeepb, 2016/06/23 07:58:32]

Done.

+TEST_F(WidgetTest, VerifyWindowCapture) {
+  Widget* widget = CreateTopLevelNativeWidget();

[tapted, 2016/06/23 02:26:28]

We should use CreateNativeDesktopWidget() for better coverage. But it will
probably mean that the test needs to go into widget_interactive_uitest.cc

[karandeepb, 2016/06/23 07:58:32]

Why is moving to widget_interactive_uitest.cc needed? Also between
CreateNativeDesktopWidget/CreateTopLevelNativeWidget, isn't it just that one
uses DesktopNativeWidgetAura and the other NativeWidgetAura?

[tapted, 2016/06/24 07:11:58]

Capture has complex interactions with the OS sometimes. E.g. I think that
another window activating on Windows can cause capture to be lost unexpectedly.
Yup. The problem is that testing NativeWidgetAura on Windows/Linux tends not to
be very exciting - we miss out on a lot of coverage, and it's somewhat redundant
with the tests also running on ChromeOS. Desktop Widgets mean not only
DesktopNativeWidgetAura gets coverage, but also DesktopWindowTreeHostX11
DesktopWindowTreeHostWin HWNDMessageHandler and a bunch of other things

I actually want to convert more of the widget_unittests to be parameterized so
they run both with/without desktop widgets. I think I made a bug for it..
somewhere.

+  widget->Show();
+  widget->native_widget_private()->SetCapture();
+  EXPECT_TRUE(widget->HasCapture());
+  widget->CloseNow();

[tapted, 2016/06/23 02:26:28]

We should test asynchronous Close() as well, since the codepath is pretty
different.

We should probably also test InitParams::WIDGET_OWNS_NATIVE_WIDGET :/

[karandeepb, 2016/06/23 07:58:32]

Done.

+}
+
 namespace {
 
 // An EventHandler which shows a Wiget upon receiving a mouse event. The Widget
 // proceeds to take capture.
 class CaptureEventConsumer : public ui::EventHandler {
  public:
   CaptureEventConsumer(Widget* widget)
       : event_count_view_(new EventCountView()), widget_(widget) {}
   ~CaptureEventConsumer() override { widget_->CloseNow(); }
 
@@ skipping 1913 matching lines @@
   EXPECT_FALSE(!!IsWindow(owned_hwnd));
   EXPECT_TRUE(!!IsWindowEnabled(top_hwnd));
 
   top_level_widget.CloseNow();
 }
 
 #endif  // defined(OS_WIN)
 
 }  // namespace test
 }  // namespace views