Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2089993003: Get rid of EUpdateStyle parameter from isEditablePosition() (Closed)

Created:
4 years, 6 months ago by yosin_UTC9
Modified:
4 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews, groby+blinkspell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of unused parameter EUpdateStyle parameter from isEditablePosition() This patch gets rid of unused parameter |EUpdateStyle| from |isEditablePosition()| to reduce code size for improving code health. This patch also introduces |needsLayoutTreeUpdate()| for checking |isEditablePosition()| called with clean layout tree. BUG=623005 TEST=n/a; no behavior changes Committed: https://crrev.com/019e4a359a1f7db417cf1132e5fd982cfacec21c Cr-Commit-Position: refs/heads/master@{#402379}

Patch Set 1 : 2016-06-22T16:53:43 #

Patch Set 2 : 2016-06-23T14:21:50 #

Patch Set 3 : 2016-06-23T15:40:03 #

Patch Set 4 : 2016-06-27T14:42:23 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 9 chunks +37 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
yosin_UTC9
PTAL
4 years, 5 months ago (2016-06-27 08:43:37 UTC) #9
yoichio
lgtm
4 years, 5 months ago (2016-06-28 02:04:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2089993003/60001
4 years, 5 months ago (2016-06-28 02:10:20 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-28 02:14:55 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 02:16:07 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/019e4a359a1f7db417cf1132e5fd982cfacec21c
Cr-Commit-Position: refs/heads/master@{#402379}

Powered by Google App Engine
This is Rietveld 408576698