ui/views/controls/webview/web_dialog_view.cc - Issue 2089933002: Context Menu Refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/webview/web_dialog_view.cc

Issue 2089933002: Context Menu Refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/webview/web_dialog_view.cc

diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc

index d8afe6ebacc5e59c7cafe63b327ed827779ae05c..5e6ce1a86e974a1a477f986abe41d3c9ba35489a 100644

--- a/ui/views/controls/webview/web_dialog_view.cc

+++ b/ui/views/controls/webview/web_dialog_view.cc

@@ -259,10 +259,12 @@ bool WebDialogView::ShouldShowDialogTitle() const {

}

bool WebDialogView::HandleContextMenu(

+ RenderFrameHost* render_frame_host,

const content::ContextMenuParams& params) {

if (delegate_)

return delegate_->HandleContextMenu(params);

- return WebDialogWebContentsDelegate::HandleContextMenu(params);

+ return WebDialogWebContentsDelegate::HandleContextMenu(

+ render_frame_host, params);

}

////////////////////////////////////////////////////////////////////////////////