extensions/browser/guest_view/extension_options/extension_options_guest.h - Issue 2089933002: Context Menu Refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_options/extension_options_guest.h

Issue 2089933002: Context Menu Refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/android/java/src/org/chromium/content/browser/input/SelectActionMode.java ('K') | « extensions/browser/guest_view/app_view/app_view_guest.cc ('k') | extensions/browser/guest_view/extension_options/extension_options_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_options/extension_options_guest.h

diff --git a/extensions/browser/guest_view/extension_options/extension_options_guest.h b/extensions/browser/guest_view/extension_options/extension_options_guest.h

index e0309f75e2f991dac7e0ea83e38d4dbbcdb0ab6c..b9af7047c5e907eb62757c1c6fc548ffdc3b5525 100644

--- a/extensions/browser/guest_view/extension_options/extension_options_guest.h

+++ b/extensions/browser/guest_view/extension_options/extension_options_guest.h

@@ -46,7 +46,8 @@ class ExtensionOptionsGuest

content::WebContents* source,

const content::OpenURLParams& params) final;

void CloseContents(content::WebContents* source) final;

- bool HandleContextMenu(const content::ContextMenuParams& params) final;

+ bool HandleContextMenu(RenderFrameHost* render_frame_host,

+ const content::ContextMenuParams& params) final;

bool ShouldCreateWebContents(

content::WebContents* web_contents,

int32_t route_id,