chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 2089933002: Context Menu Refactor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2089933002: Context Menu Refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed unnecessary code Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_web_contents_view_delegate.cc ('k') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 4e62adef62c2728090982d0f7a6e90b32f4ffb45..0d3c6f3683baa4dbe420bc447517e08768494a28 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -1398,7 +1398,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

}

ContentViewCore contentViewCore = getContentViewCore();

- if (contentViewCore != null && contentViewCore.isSelectActionBarShowing()) {

+ if (contentViewCore != null) {

contentViewCore.clearSelection();

no sievers 2016/06/23 23:16:41 just wondering... why do we need to call this here

amaralp 2016/06/24 00:45:49 The clearSelection() is necessary because if a sel

return;

}