Context Menu Refactor

chrome/browser/chromeos/login/ui/webui_login_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 377 matching lines @@
       break;
     }
     default:
       NOTREACHED() << "Unexpected notification " << type;
   }
 }
 
 // WebUILoginView private: -----------------------------------------------------
 
 bool WebUILoginView::HandleContextMenu(
+    RenderFrameHost* render_frame_host,
     const content::ContextMenuParams& params) {
-  // Do not show the context menu.
+// Do not show the context menu.

[no sievers, 2016/06/23 23:16:41]

nit: I'd remove this silly comment which doesn't explain why we do things
differently in debug builds here.

[amaralp, 2016/06/24 00:45:49]

Done.

 #ifndef NDEBUG
   return false;
 #else
   return true;
 #endif
 }
 
 void WebUILoginView::HandleKeyboardEvent(content::WebContents* source,
                                          const NativeWebKeyboardEvent& event) {
   if (forward_keyboard_event_) {
@@ skipping 139 matching lines @@
   if (should_emit_login_prompt_visible_) {
     VLOG(1) << "Login WebUI >> login-prompt-visible";
     chromeos::DBusThreadManager::Get()->GetSessionManagerClient()->
         EmitLoginPromptVisible();
   }
 
   webui_visible_ = true;
 }
 
 }  // namespace chromeos