Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 2089883002: Make crypto::RSAPrivateKey's factory functions return unique_ptrs (Closed)

Created:
4 years, 6 months ago by Ryan Sleevi
Modified:
4 years, 6 months ago
Reviewers:
Devlin, davidben, yurys
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, cbentzel+watch_chromium.org, extensions-reviews_chromium.org, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make crypto::RSAPrivateKey's factory functions return unique_ptrs BUG=none TBR=yurys@chromium.org Committed: https://crrev.com/d1afa1eef63c34344e6a83481b2a86e369eecb95 Cr-Commit-Position: refs/heads/master@{#401201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -42 lines) Patch
M chrome/browser/devtools/device/usb/android_rsa.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_rsa.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/devtools/device/usb/usb_device_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_creator.h View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_creator.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M crypto/rsa_private_key.h View 2 chunks +5 lines, -5 lines 0 comments Download
M crypto/rsa_private_key.cc View 2 chunks +17 lines, -19 lines 0 comments Download
M net/quic/crypto/proof_source_chromium.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
Ryan Sleevi
4 years, 6 months ago (2016-06-21 23:12:10 UTC) #2
Ryan Sleevi
rdevlin, yurys: If you get to this, great, otherwise will TBR when David LGs, since ...
4 years, 6 months ago (2016-06-21 23:14:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089883002/1
4 years, 6 months ago (2016-06-21 23:15:20 UTC) #6
Devlin
extensions lgtm
4 years, 6 months ago (2016-06-22 00:15:40 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/242886)
4 years, 6 months ago (2016-06-22 01:03:31 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089883002/1
4 years, 6 months ago (2016-06-22 02:56:08 UTC) #11
davidben
lgtm
4 years, 6 months ago (2016-06-22 03:08:53 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-22 03:51:35 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089883002/1
4 years, 6 months ago (2016-06-22 03:57:03 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 04:01:01 UTC) #21
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 04:05:37 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1afa1eef63c34344e6a83481b2a86e369eecb95
Cr-Commit-Position: refs/heads/master@{#401201}

Powered by Google App Engine
This is Rietveld 408576698