Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2089823003: Re-enable calls on |display_manager_| for Windows in DisplayManagerTestApi (Closed)

Created:
4 years, 6 months ago by tdanderson
Modified:
4 years, 6 months ago
Reviewers:
msw, James Cook
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable calls on |display_manager_| for Windows in DisplayManagerTestApi Try re-enabling the calls in DisplayManagerTestApi::UpdateDisplay() which previously caused tests to hang on Windows. BUG=584038 TEST=ash_unittests Committed: https://crrev.com/e46402d0270e8e957310a1c27f0acc5049fca292 Cr-Commit-Position: refs/heads/master@{#401421}

Patch Set 1 #

Patch Set 2 : fix trybot failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ash/test/display_manager_test_api.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tdanderson
msw@, please take a look. Also let me know which of the tests tagged with ...
4 years, 6 months ago (2016-06-22 19:27:41 UTC) #2
msw
lgtm; I can try to re-enable the crbug.com/584038 tests incrementally... I have no clue what ...
4 years, 6 months ago (2016-06-22 19:57:47 UTC) #3
tdanderson
James, can you please take a look? Mike, please wait until my other CL lands ...
4 years, 6 months ago (2016-06-22 20:38:40 UTC) #5
James Cook
lgtm
4 years, 6 months ago (2016-06-22 21:05:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089823003/20001
4 years, 6 months ago (2016-06-22 21:09:23 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 21:56:12 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 21:58:53 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e46402d0270e8e957310a1c27f0acc5049fca292
Cr-Commit-Position: refs/heads/master@{#401421}

Powered by Google App Engine
This is Rietveld 408576698