Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: cc/output/output_surface_unittest.cc

Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: copytextureformat: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/output/output_surface.h ('k') | cc/output/overlay_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/output_surface_unittest.cc
diff --git a/cc/output/output_surface_unittest.cc b/cc/output/output_surface_unittest.cc
index 38285da59c19d19ebba96ba22c8c1f098d2ba132..fb578f143439cc49d83dbde335c35f0769777a00 100644
--- a/cc/output/output_surface_unittest.cc
+++ b/cc/output/output_surface_unittest.cc
@@ -22,11 +22,12 @@ namespace {
class TestOutputSurface : public OutputSurface {
public:
- explicit TestOutputSurface(scoped_refptr<ContextProvider> context_provider)
+ explicit TestOutputSurface(
+ scoped_refptr<TestContextProvider> context_provider)
: OutputSurface(std::move(context_provider), nullptr, nullptr) {}
- TestOutputSurface(scoped_refptr<ContextProvider> context_provider,
- scoped_refptr<ContextProvider> worker_context_provider)
+ TestOutputSurface(scoped_refptr<TestContextProvider> context_provider,
+ scoped_refptr<TestContextProvider> worker_context_provider)
: OutputSurface(std::move(context_provider),
std::move(worker_context_provider),
nullptr) {}
@@ -35,7 +36,7 @@ class TestOutputSurface : public OutputSurface {
std::unique_ptr<SoftwareOutputDevice> software_device)
: OutputSurface(nullptr, nullptr, std::move(software_device)) {}
- TestOutputSurface(scoped_refptr<ContextProvider> context_provider,
+ TestOutputSurface(scoped_refptr<TestContextProvider> context_provider,
std::unique_ptr<SoftwareOutputDevice> software_device)
: OutputSurface(std::move(context_provider),
nullptr,
@@ -45,6 +46,10 @@ class TestOutputSurface : public OutputSurface {
client_->DidSwapBuffers();
client_->DidSwapBuffersComplete();
}
+ uint32_t GetFramebufferCopyTextureFormat() override {
+ // TestContextProvider has no real framebuffer, just use RGB.
+ return GL_RGB;
+ }
void DidSwapBuffersForTesting() { client_->DidSwapBuffers(); }
« no previous file with comments | « cc/output/output_surface.h ('k') | cc/output/overlay_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698