cc/output/output_surface.h - Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/output_surface.h

Issue 2089753003: cc: Use the correct internal format for glCopyTexImage2D calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: copytextureformat: without-the-broken-thing-for-testing-lol Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/output_surface.h

diff --git a/cc/output/output_surface.h b/cc/output/output_surface.h

index f9ec618996692697dc9b556337f6dd222cffa068..95a52c1edd05ec325c41949eafc7b4e9fdb49673 100644

--- a/cc/output/output_surface.h

+++ b/cc/output/output_surface.h

@@ -132,6 +132,9 @@ class CC_EXPORT OutputSurface : public base::trace_event::MemoryDumpProvider {

virtual void ForceReclaimResources() {}

virtual void BindFramebuffer();

+ // Gives the GL internal format that should be used for calling CopyTexImage2D

+ // when the framebuffer is bound via BindFramebuffer().

+ virtual uint32_t GetFramebufferCopyTextureFormat() = 0;

// The implementation may destroy or steal the contents of the CompositorFrame

// passed in (though it will not take ownership of the CompositorFrame

« cc/output/gl_renderer.h ('K') | « cc/output/gl_renderer_unittest.cc ('k') | cc/output/output_surface_unittest.cc » ('j') | no next file with comments »