cc: Use the correct internal format for glCopyTexImage2D calls.

blimp/client/feature/compositor/blimp_context_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_CONTEXT_PROVIDER_H_
 #define BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_CONTEXT_PROVIDER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 25 matching lines @@
   gpu::Capabilities ContextCapabilities() override;
   gpu::gles2::GLES2Interface* ContextGL() override;
   gpu::ContextSupport* ContextSupport() override;
   class GrContext* GrContext() override;
   void InvalidateGrContext(uint32_t state) override;
   base::Lock* GetLock() override;
   void DeleteCachedResources() override;
   void SetLostContextCallback(
       const LostContextCallback& lost_context_callback) override;
 
+  uint32_t GetCopyTextureInternalFormat();

[Wez, 2016/06/22 21:02:21]

nit: Please add a comment e.g. "Returns the GL texture format, for use by the
owning OutputSurface implementation." so it's clear why we need this here, in
addition to the ContextProvider interface.

nit: Should ContextProvider interface have this method too, so this becomes an
override? Are there ContextProviders for which the texture format is not
relevant, or is well-known to the caller..?

[danakj, 2016/06/22 21:06:50]

Done, here and on the other context providers too.
Since every place that wants this data knows the concrete type of the
ContextProvider, I'd rather not make it part of the general API.

[Wez, 2016/06/22 21:08:14]

Acknowledged.

+
  protected:
   BlimpContextProvider(
       gfx::AcceleratedWidget widget,
       gpu::GpuMemoryBufferManager* gpu_memory_buffer_manager);
   ~BlimpContextProvider() override;
 
  private:
   void OnLostContext();
 
   base::ThreadChecker main_thread_checker_;
   base::ThreadChecker context_thread_checker_;
 
   std::unique_ptr<gpu::GLInProcessContext> context_;
   std::unique_ptr<skia_bindings::GrContextForGLES2Interface> gr_context_;
 
   LostContextCallback lost_context_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(BlimpContextProvider);
 };
 
 }  // namespace client
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_FEATURE_COMPOSITOR_BLIMP_CONTEXT_PROVIDER_H_