Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2089753002: Rebaseline Layout Test for issue v8:4955 (Closed)

Created:
4 years, 6 months ago by jwolfe
Modified:
4 years, 6 months ago
Reviewers:
adamk
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline Layout Test for issue v8:4955 The expected output of inspector-protocol/console/console-let-const-with-api.html needs to change which type of error is expected from variable redeclaration. It used to be TypeError; now it's SyntaxError. BUG=621382 LOG=n R=adamk Committed: https://crrev.com/9ae52a5e1be50f8b38d215cd65754dd23f6c00ef Cr-Commit-Position: refs/heads/master@{#401389}

Patch Set 1 #

Patch Set 2 : include the whole patch this time, take 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jwolfe
I actually haven't run these changes locally due to https://bugs.chromium.org/p/chromium/issues/detail?id=621695 , but I think this ...
4 years, 6 months ago (2016-06-21 20:42:39 UTC) #1
adamk
This will have to wait until your V8 patch "rolls" into Chromium (which is pinned ...
4 years, 6 months ago (2016-06-21 20:46:40 UTC) #2
jwolfe
My analysis is that the v8 patch has rolled now, so I'll start the commit.
4 years, 6 months ago (2016-06-22 18:11:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089753002/20001
4 years, 6 months ago (2016-06-22 18:12:15 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 20:00:03 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 20:02:14 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ae52a5e1be50f8b38d215cd65754dd23f6c00ef
Cr-Commit-Position: refs/heads/master@{#401389}

Powered by Google App Engine
This is Rietveld 408576698