Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2089733002: [parser] only parse async arrow function when necessary (Closed)

Created:
4 years, 6 months ago by caitp (gmail)
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] only parse async arrow function when necessary Previously, an async arrow function would be parsed if any valid ConditionalExpression began with the identifier "async", and its following token was on the same line. So for example, `async.bar foo => 1` was parsed as a valid async arrow function. This patch corrects this behaviour by asserting that the following token is a valid arrow parameters start. BUG=v8:4483 R=littledan@chromium.org, henrique.ferreiro@gmail.com Committed: https://crrev.com/e45fba811fbf15751c3464c0d3973f6f8ee5c934 Cr-Commit-Position: refs/heads/master@{#37154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M src/parsing/parser-base.h View 3 chunks +12 lines, -7 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
caitp (gmail)
Hey, PTAL guys.
4 years, 6 months ago (2016-06-21 19:04:58 UTC) #1
Dan Ehrenberg
lgtm
4 years, 6 months ago (2016-06-21 19:16:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089733002/1
4 years, 6 months ago (2016-06-21 19:21:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-21 19:46:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 19:48:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e45fba811fbf15751c3464c0d3973f6f8ee5c934
Cr-Commit-Position: refs/heads/master@{#37154}

Powered by Google App Engine
This is Rietveld 408576698