src/execution.cc - Issue 2089703004: Further streamline HandleApiCall

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/execution.cc

Issue 2089703004: Further streamline HandleApiCall (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/execution.cc

diff --git a/src/execution.cc b/src/execution.cc

index 96c88c3a3104ea5f168c690e3bcfb7b2bd70c6a1..243bb8a9117ae5998384b1146c21e8a0ec4f923e 100644

--- a/src/execution.cc

+++ b/src/execution.cc

@@ -140,7 +140,8 @@ MaybeHandle<Object> Execution::Call(Isolate* isolate, Handle<Object> callable,

SaveContext save(isolate);

isolate->set_context(function->context());

DCHECK(function->context()->global_object()->IsJSGlobalObject());

- auto value = Builtins::InvokeApiFunction(function, receiver, argc, argv);

+ auto value =

+ Builtins::InvokeApiFunction(isolate, function, receiver, argc, argv);

bool has_exception = value.is_null();

DCHECK(has_exception == isolate->has_pending_exception());

if (has_exception) {

« no previous file with comments | « src/builtins.cc ('k') | src/objects.h » ('j') | no next file with comments »