Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2089703004: Further streamline HandleApiCall (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Further streamline HandleApiCall The CL avoids superfluous conversions / reboxing and handlescopes. BUG= Committed: https://crrev.com/813f231896dcd11e96acfa74fc5a6f62b1b500a9 Cr-Commit-Position: refs/heads/master@{#37180}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -52 lines) Patch
M src/builtins.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 6 chunks +42 lines, -27 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 3 chunks +8 lines, -21 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 6 months ago (2016-06-22 09:51:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 6 months ago (2016-06-22 09:54:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2089703004/1
4 years, 6 months ago (2016-06-22 09:55:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-22 10:23:25 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 10:23:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/813f231896dcd11e96acfa74fc5a6f62b1b500a9
Cr-Commit-Position: refs/heads/master@{#37180}

Powered by Google App Engine
This is Rietveld 408576698