src/crankshaft/lithium.cc - Issue 2089673002: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium.cc

Issue 2089673002: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Reland Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/lithium.cc

diff --git a/src/crankshaft/lithium.cc b/src/crankshaft/lithium.cc

index d34b04f5da022ccaa582777c14db0fbb18f051cd..5aed08718ade4a406479d278d81e3c128bdf7adf 100644

--- a/src/crankshaft/lithium.cc

+++ b/src/crankshaft/lithium.cc

@@ -469,8 +469,7 @@ Handle<Code> LChunk::Codegen() {

jit_handler_data));

CodeGenerator::PrintCode(code, info());

- DCHECK(!(info()->isolate()->serializer_enabled() &&

- info()->GetMustNotHaveEagerFrame() &&

+ DCHECK(!(info()->GetMustNotHaveEagerFrame() &&

generator.NeedsEagerFrame()));

return code;

}

« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | no next file » | no next file with comments »