Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: src/code-stubs-hydrogen.cc

Issue 2089673002: Reland: [Crankshaft] Always check for stubs marked to not require an eager frame. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Reland Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs-hydrogen.cc
diff --git a/src/code-stubs-hydrogen.cc b/src/code-stubs-hydrogen.cc
index 672023c0e01f21d9f9defc2eeef9bf14a9f811b6..b60954b60d5da78a34530bb549345d20177f1559 100644
--- a/src/code-stubs-hydrogen.cc
+++ b/src/code-stubs-hydrogen.cc
@@ -467,9 +467,14 @@ HValue* CodeStubGraphBuilder<FastCloneShallowArrayStub>::BuildCodeStub() {
HValue* closure = GetParameter(0);
HValue* literal_index = GetParameter(1);
+ // TODO(turbofan): This codestub has regressed to need a frame on ia32 at some
+ // point and wasn't caught since it wasn't built in the snapshot. We should
+ // probably just replace with a TurboFan stub rather than fixing it.
+#if !V8_TARGET_ARCH_IA32
// This stub is very performance sensitive, the generated code must be tuned
// so that it doesn't build and eager frame.
info()->MarkMustNotHaveEagerFrame();
+#endif
HValue* literals_array = Add<HLoadNamedField>(
closure, nullptr, HObjectAccess::ForLiteralsPointer());
@@ -2061,7 +2066,12 @@ HValue* CodeStubGraphBuilder<RegExpConstructResultStub>::BuildCodeStub() {
HValue* index = GetParameter(RegExpConstructResultStub::kIndex);
HValue* input = GetParameter(RegExpConstructResultStub::kInput);
+ // TODO(turbofan): This codestub has regressed to need a frame on ia32 at some
+ // point and wasn't caught since it wasn't built in the snapshot. We should
+ // probably just replace with a TurboFan stub rather than fixing it.
+#if !V8_TARGET_ARCH_IA32
info()->MarkMustNotHaveEagerFrame();
+#endif
return BuildRegExpConstructResult(length, index, input);
}
« no previous file with comments | « no previous file | src/crankshaft/lithium.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698