[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

R=groby@chromium.org
BUG=618040
Committed: https://chromium.googlesource.com/chromium/src/+/cf3e7e2ae4087ed941106aee0411c786dc4f112d

[mmoroz, 2016-06-21 12:43:58]

On 2016/06/21 12:28:36, mmoroz wrote:

Hm, here should be two files changed:

$ git diff HEAD~
diff --git a/third_party/hunspell/fuzz/hunspell_fuzzer.cc
b/third_party/hunspell/fuzz/hunspell_fuzzer.cc
index 9dc4fd0..47abae7 100644
--- a/third_party/hunspell/fuzz/hunspell_fuzzer.cc
+++ b/third_party/hunspell/fuzz/hunspell_fuzzer.cc
@@ -14,9 +14,8 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data,
size_t size) {
   if (!size)
     return 0;
   
-  static Hunspell* hunspell = new Hunspell(
-      reinterpret_cast<const unsigned char*>(kHunspellDictionary),
-      sizeof(kHunspellDictionary));
+  static Hunspell* hunspell = new Hunspell(kHunspellDictionary,
+                                           sizeof(kHunspellDictionary));
 
   std::string data_string(reinterpret_cast<const char*>(data), size);
   hunspell->spell(data_string.c_str());
diff --git a/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
b/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
index c34002b..92c91e4 100644
--- a/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
+++ b/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
@@ -27,48920 +27,55775 @@
 
 
<...>

[mmoroz, 2016-06-23 08:04:45]

On 2016/06/21 12:43:58, mmoroz wrote:
> On 2016/06/21 12:28:36, mmoroz wrote:
> 
> Hm, here should be two files changed:
> 
> $ git diff HEAD~
> diff --git a/third_party/hunspell/fuzz/hunspell_fuzzer.cc
> b/third_party/hunspell/fuzz/hunspell_fuzzer.cc
> index 9dc4fd0..47abae7 100644
> --- a/third_party/hunspell/fuzz/hunspell_fuzzer.cc
> +++ b/third_party/hunspell/fuzz/hunspell_fuzzer.cc
> @@ -14,9 +14,8 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data,
> size_t size) {
>    if (!size)
>      return 0;
>    
> -  static Hunspell* hunspell = new Hunspell(
> -      reinterpret_cast<const unsigned char*>(kHunspellDictionary),
> -      sizeof(kHunspellDictionary));
> +  static Hunspell* hunspell = new Hunspell(kHunspellDictionary,
> +                                           sizeof(kHunspellDictionary));
>  
>    std::string data_string(reinterpret_cast<const char*>(data), size);
>    hunspell->spell(data_string.c_str());
> diff --git a/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
> b/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
> index c34002b..92c91e4 100644
> --- a/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
> +++ b/third_party/hunspell/fuzz/hunspell_fuzzer_dictionary.h
> @@ -27,48920 +27,55775 @@
>  
>  
> <...>

Wooho, I've got the .h file here! Now trying to upload it with correct
dictionary.

[mmoroz, 2016-06-23 08:12:41]

Ok, it doesn't want to display updated header file "(Patch set is too large to
download)". But this isn't a big problem. PTAL

[groby-ooo-7-16, 2016-06-23 20:52:16]

I guess I'll just believe it's the right content. "What could go wrong" in a
security context is always fun ;)

OK, kidding aside, this is LGTM given it's test-only data.

[mmoroz, 2016-06-24 08:32:08]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-06-24 08:32:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2089623002/80001

[mmoroz, 2016-06-24 08:33:52]

On 2016/06/23 20:52:16, groby wrote:
> I guess I'll just believe it's the right content. "What could go wrong" in a
> security context is always fun ;)
> 
> OK, kidding aside, this is LGTM given it's test-only data.

Thanks groby@, hopefully I won't let you down :)

[commit-bot: I haz the power, 2016-06-24 08:57:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 08:57:26]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmoroz, 2016-06-24 09:05:44]

On 2016/06/24 08:57:26, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Trybots don't see changes in the header... OK

[commit-bot: I haz the power, 2016-06-24 11:08:36]

Description was changed from

==========
[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

R=groby@chromium.org
BUG=618040
==========

to

==========
[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

R=groby@chromium.org
BUG=618040

Committed: https://crrev.com/cf3e7e2ae4087ed941106aee0411c786dc4f112d
Cr-Commit-Position: refs/heads/master@{#401849}
==========

[commit-bot: I haz the power, 2016-06-24 11:08:37]

Patchset 10 (id:??) landed as
https://crrev.com/cf3e7e2ae4087ed941106aee0411c786dc4f112d
Cr-Commit-Position: refs/heads/master@{#401849}

[mmoroz, 2016-06-24 11:09:34]

Description was changed from

==========
[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

R=groby@chromium.org
BUG=618040

Committed: https://crrev.com/cf3e7e2ae4087ed941106aee0411c786dc4f112d
Cr-Commit-Position: refs/heads/master@{#401849}
==========

to

==========
[libfuzzer] Use contents of .bdic file as a dictionary for hunspell_fuzzer.

R=groby@chromium.org
BUG=618040

Committed:
https://chromium.googlesource.com/chromium/src/+/cf3e7e2ae4087ed941106aee0411...
==========

[mmoroz, 2016-06-24 11:09:35]

Committed patchset #10 (id:110001) manually as
cf3e7e2ae4087ed941106aee0411c786dc4f112d (presubmit successful).